tls: use for...of#30961
Closed
tls: use for...of #30961
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading. Please reload this page.
addaleax approved these changes Dec 14, 2019
trivikr added the author ready 
Collaborator
nodejs-github-bot commented Dec 14, 2019
Trott approved these changes Dec 14, 2019
BridgeAR approved these changes Dec 15, 2019
targos approved these changes Dec 15, 2019
jasnell approved these changes Dec 15, 2019
jasnell approved these changes Dec 15, 2019
Collaborator
nodejs-github-bot commented Dec 16, 2019
Collaborator
nodejs-github-bot commented Dec 16, 2019
Collaborator
nodejs-github-bot commented Dec 17, 2019
trivikr added a commit to trivikr/node that referenced this pull request Dec 17, 2019
PR-URL: nodejs#30961 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
trivikr commented Dec 17, 2019
Landed in 7f536f2 |
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30961 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30961 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30961 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for regular expression
for \([^\.]*.lengthinliband made changes in_tls_*filesRefs: #30910 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes