Skip to content

Conversation

@Trott
Copy link
Member

Minor editing for clarity and concision.

@TrottTrott added the doc Issues and PRs related to the documentations. label Sep 28, 2015
@thefourtheye
Copy link
Contributor

Recursive support for Windows has been added only recently and I assume this is going to be an ongoing process. So, we may not require that change.

cc @saghul

@Trott
Copy link
MemberAuthor

@thefourtheye I'm not sure I understand what you mean. The only change I'm proposing for that part of the doc is to change currently supported on OS X and Windows to only supported on OS X and Windows. I think that's an improvement because:

  • The word currently is superfluous. Whatever you put in the documentation, it is assumed to be the current state of the API.
  • The word only makes it explicit that it is not supported anywhere else. Leaving out only makes it ambiguous. Is it supported on OS X and Windows as well as other platforms? Or just those two platforms and nowhere else?

Am I misunderstanding something?

@thefourtheye
Copy link
Contributor

Hmmm okay. LGTM then

@targos
Copy link
Member

LGTM

@saghul
Copy link
Member

IMHO it can be trimmed further.

"Only FSEvents supports this type of file watching so it is unlikely any additional platforms will be added soon."

Here "FSEvents" refers to the OSX API, but since we added Windows support I don't think we should say it's unlikely that we add more.

Removed "Only FSEvents supports this type of file watching so it is unlikely any additional platforms will be added soon." Per @saghul, "FSEvents" refers to the OSX API, but since we added Windows support it may not be unlikely that we add more.
@Trott
Copy link
MemberAuthor

@saghul OK, trimmed further. Thanks. How's it look now? /cc @thefourtheye@targos

@thefourtheye
Copy link
Contributor

LGTM

2 similar comments
@targos
Copy link
Member

LGTM

@saghul
Copy link
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Sep 30, 2015
Removed "Only FSEvents supports this type of file watching so it is unlikely any additional platforms will be added soon." Per @saghul, "FSEvents" refers to the OSX API, but since we added Windows support it may not be unlikely that we add more. PR-URL: nodejs#3097 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@Trott
Copy link
MemberAuthor

Landed in 0e4b772

@TrottTrott closed this Sep 30, 2015
Trott added a commit that referenced this pull request Oct 2, 2015
Removed "Only FSEvents supports this type of file watching so it is unlikely any additional platforms will be added soon." Per @saghul, "FSEvents" refers to the OSX API, but since we added Windows support it may not be unlikely that we add more. PR-URL: #3097 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@rvaggrvagg mentioned this pull request Oct 3, 2015
@TrottTrott deleted the doc-fs branch January 13, 2022 22:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@thefourtheye@targos@saghul