test: add missing test flags#30971
Closed
test: add missing test flags #30971
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. nodejs#30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag.
Trott approved these changes Dec 15, 2019
Member
Trott commented Dec 15, 2019
Fast-track to unblock #30963? |
Member
Trott commented Dec 15, 2019
Or another suggestion: Close this PR and add this commit as a first commit in #30963. |
richardlau approved these changes Dec 15, 2019
Collaborator
nodejs-github-bot commented Dec 15, 2019
addaleax added the author ready Member
Trott commented Dec 15, 2019
Landed in 2097a6f |
Trott pushed a commit that referenced this pull request Dec 15, 2019
test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: #30971 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: #30971 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: #30971 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: #30971 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-wasi-start-validation.jsshould require the--experimental-wasi-unstable-preview0flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes