Skip to content

benchmark: manywrites backpressure#30977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronag wants to merge 1 commit into from
Closed

benchmark: manywrites backpressure #30977

ronag wants to merge 1 commit into from

Conversation

@ronag
Copy link
Member

@ronagronag commented Dec 15, 2019•
edited
Loading

Make manywrites benchmark a bit more realistic by taking backpressure into account. Otherwise memory usage would no correspond well with real world usage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem. labels Dec 15, 2019
@ronagronag changed the title bench: manywrites back pressurebench: manywrites backpressureDec 15, 2019
@ronag
Copy link
MemberAuthor

ronag commented Dec 15, 2019

What's the correct "subsystem" for bench?

@lpinca
Copy link
Member

lpinca commented Dec 15, 2019

benchmark

@ronag
benchmark: manywrites back pressure
b06f8fe
Make manywrites benchmark a bit more realistic by taking back pressure into account. Otherwise memory usage would no correspond well with real world usage.
@ronagronagforce-pushed the manywrites-backpressuse branch from 45cfb45 to b06f8feCompareDecember 15, 2019 15:14
@ronagronag changed the title bench: manywrites backpressurebenchmark: manywrites backpressureDec 15, 2019
@Fishrock123
Copy link
Contributor

Fishrock123 commented Dec 16, 2019•
edited
Loading

Sure, no good use of streams will cause this, but I do wonder a bit if the old one isn't still useful somehow? Idk.

@Trott
Copy link
Member

Trott commented Dec 17, 2019

benchmark CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/10986/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27764/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27770/

@Trott
Copy link
Member

Trott commented Dec 18, 2019

Landed in ea86f8c

@TrottTrott closed this Dec 18, 2019
Trott pushed a commit that referenced this pull request Dec 18, 2019
@ronag@Trott
benchmark: update manywrites back pressure
ea86f8c
Make manywrites benchmark a bit more realistic by taking back pressure into account. Otherwise memory usage would no correspond well with real world usage. PR-URL: #30977 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@ronag@BridgeAR
benchmark: update manywrites back pressure
0e864a3
Make manywrites benchmark a bit more realistic by taking back pressure into account. Otherwise memory usage would no correspond well with real world usage. PR-URL: #30977 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@ronag@targos
benchmark: update manywrites back pressure
1333798
Make manywrites benchmark a bit more realistic by taking back pressure into account. Otherwise memory usage would no correspond well with real world usage. PR-URL: #30977 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@ronag@BethGriggs
benchmark: update manywrites back pressure
d5bebc3
Make manywrites benchmark a bit more realistic by taking back pressure into account. Otherwise memory usage would no correspond well with real world usage. PR-URL: #30977 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@lpincalpincalpinca approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+1 more reviewer

@Fishrock123Fishrock123Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag@lpinca@Fishrock123@Trott@nodejs-github-bot@BridgeAR