Skip to content

benchmark: include writev & callback in benchmark#31066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronag wants to merge 5 commits into from
Closed

benchmark: include writev & callback in benchmark #31066

ronag wants to merge 5 commits into from

Conversation

@ronag
Copy link
Member

@ronagronag commented Dec 23, 2019

Currently we only consider write when benchmarking.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag
benchmark: include writev in benchmark
d1603cd
Currently we only consider write when benchmarking.
@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem. labels Dec 23, 2019
@ronagronag changed the title benchmark: include writev in benchmarkbenchmark: include writev & callback in benchmarkDec 23, 2019
lundibundi
lundibundi approved these changes Dec 23, 2019
View reviewed changes
@ronagronag mentioned this pull request Dec 23, 2019
Closed
4 tasks
BridgeAR
BridgeAR requested changes Dec 24, 2019
View reviewed changes
Copy link
Member

@BridgeARBridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually requires the following test to be changed:

test/benchmark/test-benchmark-streams.js

@ronag
Copy link
MemberAuthor

ronag commented Dec 24, 2019

This actually requires the following test to be changed:

test/benchmark/test-benchmark-streams.js

Sorry, this is new for me. What is that and how does it need to be changed?

@BridgeAR
Copy link
Member

BridgeAR commented Dec 24, 2019

If you run the test with this addition, it will fail due to the added options that are not included in the test. It is a way to verify that at least one benchmark option passes for all benchmark files of the specific subsystem.

You could add something like writev: 'yes', callback: 'no'.

@ronagronag requested a review from BridgeARDecember 25, 2019 10:27
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 25, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Dec 25, 2019

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4115/

Marking as author ready. The benchmark test should be run while landing to verify that it works properly.

@BridgeAR
Copy link
Member

BridgeAR commented Dec 25, 2019•
edited
Loading

Landed in f68285b 🎉

BridgeAR pushed a commit that referenced this pull request Dec 25, 2019
@ronag@BridgeAR
benchmark: include writev in benchmark
f68285b
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@ronag@BridgeAR
benchmark: include writev in benchmark
01fd3be
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@ronag@targos
benchmark: include writev in benchmark
d5c0e4d
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@ronag@BethGriggs
benchmark: include writev in benchmark
471c59b
Currently we only consider write when benchmarking. PR-URL: #31066 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
@snyk-botsnyk-bot mentioned this pull request Jun 1, 2021
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+1 more reviewer

@lundibundilundibundilundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag@BridgeAR@addaleax@lundibundi@nodejs-github-bot