stream: group all properties using defineProperties#31144
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the stream 
Collaborator
nodejs-github-bot commented Dec 31, 2019
Member
Trott commented Dec 31, 2019
@nodejs/streams |
BridgeAR approved these changes Jan 1, 2020
BridgeAR added the author ready Collaborator
nodejs-github-bot commented Jan 1, 2020
lpinca approved these changes Jan 1, 2020
ZYSzys approved these changes Jan 2, 2020
jasnell approved these changes Jan 2, 2020
BridgeAR pushed a commit that referenced this pull request Jan 2, 2020
PR-URL: #31144 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
BridgeAR commented Jan 2, 2020
Landed in 2257e80 🎉 |
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
PR-URL: #31144 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
ronag commented Jan 4, 2020
@antsmartian: Would you mind doing the same for |
4 tasks
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #31144 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #31144 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #31144 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Feb 10, 2020
PR-URL: #31187 Refs: #31144 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
4 tasks
ronag pushed a commit to nxtedition/node that referenced this pull request Mar 9, 2020
PR-URL: nodejs#31187 Refs: nodejs#31144 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: nodejs#32164
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
Backport-PR-URL: #32164 PR-URL: #31187 Refs: #31144 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 20, 2020
Backport-PR-URL: #32164 PR-URL: #31187 Refs: #31144 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
lundibundi added a commit to lundibundi/node that referenced this pull request Aug 23, 2020
Looks like they have been accidentally moved in nodejs#31144. This also adds the proxy properties to Readable since they have been present all this time and removing them would be breaking.
4 tasks
lundibundi added a commit to lundibundi/node that referenced this pull request Aug 23, 2020
Looks like they have been accidentally moved in nodejs#31144.
nodejs-github-bot pushed a commit that referenced this pull request Sep 1, 2020
Looks like they have been accidentally moved in #31144. PR-URL: #34886 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 2, 2020
Looks like they have been accidentally moved in #31144. PR-URL: #34886 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 3, 2020
Looks like they have been accidentally moved in #31144. PR-URL: #34886 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Looks like they have been accidentally moved in nodejs#31144. PR-URL: nodejs#34886 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple refactor. Moved all the property definition into a single block and removed duplicated comments across the file.