lib: enhance use of Error from primordials#31163
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the lib / src 
ContributorAuthor
Sebastien-Ahkrin commented Jan 2, 2020
Refs: #30697 |
Member
BridgeAR commented Jan 2, 2020
Does this have any impact on |
Member
targos commented Jan 2, 2020
No, the object is the same as the global one. |
Collaborator
nodejs-github-bot commented Jan 2, 2020
BridgeAR approved these changes Jan 2, 2020
BridgeAR added the author ready 
jasnell approved these changes Jan 2, 2020
devnexen approved these changes Jan 3, 2020
ContributorAuthor
Sebastien-Ahkrin commented Jan 3, 2020
This PR is errored with the JS test suite in the "parallel/test-tick-processor-arguments" test ... i can reproduce the error now in my computer . i will investigate 😄 |
Sebastien-Ahkrinforce-pushed the ErrorPrimordials branch from 2b5695f to 9c1d309CompareContributorAuthor
Sebastien-Ahkrin commented Jan 3, 2020
@targos found the error 😄 so its only because the file v8-prof-polyfill can't contain any primordials. /* eslint-disable no-restricted-globals */I hope this will help you :) |
Trott approved these changes Jan 4, 2020
Collaborator
nodejs-github-bot commented Jan 4, 2020
Trott approved these changes Jan 4, 2020
trivikr approved these changes Jan 4, 2020
Collaborator
nodejs-github-bot commented Jan 4, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 4, 2020
PR-URL: nodejs#31163 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Member
Trott commented Jan 4, 2020
Landed in c9b93e2 |
targos pushed a commit that referenced this pull request Jan 6, 2020
PR-URL: #31163 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #31163 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #31163 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Now, in this PR I have added Error in the primordials eslint
so have created a line in "/lib/.eslintrc.yaml".
And just import Error :).
I hope this new PR will help you :x