lib: move GLOBAL and root aliases to EOL#31167

jasnell · 2020-01-02T22:03:22Z

GLOBAL and root have been long deprecated.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Trott · 2020-01-02T23:28:54Z

Might we decide to never EOL this, similar to how we are likely to never remove sys? Isn't the cost of leaving around root and GLOBAL as deprecated aliases for global close to zero, while the cost for the ecosystem of removing them is non-zero?

jasnell · 2020-01-02T23:55:16Z

The cost of keeping these around is definitely not zero really as it contributes to a significant amount of legacy cruft that bloats the code and makes things more difficult to maintain in the long run. I'm fine with keeping these around longer if there are actively used modules in the ecosystem that still use them; alternatively, we can proactively open PR fixes in any module that does.

addaleax · 2020-01-03T00:45:43Z

This should be okay, given that the runtime deprecation effectively already makes these broken, but the maintenance cost here is close to zero, to be fair.

Trott · 2020-01-06T06:33:19Z

This change causes underscore tests to fail in CITGM because GLOBAL is used in test/object.js in the most recent release of underscore. https://ci.nodejs.org/job/citgm-smoker/2189/testReport/

This issue was fixed by @BridgeAR in March 2019 but that change has yet to make it into a release. jashkenas/underscore@5304f86

jashkenas · 2020-01-06T21:29:11Z

This issue was fixed by @BridgeAR in March 2019 but that change has yet to make it into a release. jashkenas/underscore@5304f86

I was pinged by @BridgeAR today, and published the updated test case as part of version 1.9.2.

BridgeAR · 2020-01-09T22:17:54Z

@nodejs/tsc PTAL. This could use some reviews.

Trott · 2020-01-10T00:58:16Z

lib/internal/bootstrap/node.js

With this line removed, the file fails linting because ObjectDefineProperties is defined but never used.

GLOBAL and root have been long deprecated.

jasnell · 2020-02-03T16:46:39Z

Ping @nodejs/tsc ... needs one more TSC signoff

jasnell · 2020-02-03T18:08:52Z

On these EOL PRs, I'm perfectly fine to close these without action if there's no TSC support.

jasnell · 2020-02-04T04:26:28Z

This has two TSC signoffs so technically could land but @Trott's outstanding concern should be addressed. Given that there are several of these, likely a good idea to discuss on the TSC call. Adding tsc-agenda

Trott · 2020-02-04T04:33:07Z

This has two TSC signoffs so technically could land

Needs a CI and a CITGM, but yeah, it can land otherwise.

Hopefully, TSC members will chime in here rather than waiting for the meeting. The meeting will only be attended by a fraction of the TSC, whereas the issue tracker allows us all to participate.

nodejs-github-bot · 2020-02-04T04:42:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28907/

jasnell · 2020-02-04T14:43:29Z

Lint failed to run properly, trying again.

nodejs-github-bot · 2020-02-04T14:44:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28918/

jasnell · 2020-02-04T14:44:42Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2255/

jasnell · 2020-02-05T02:43:02Z

CITGM results do not appear to show any relevant failures

mcollina

lgtm

GLOBAL and root have been long deprecated. PR-URL: #31167 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

jasnell · 2020-02-06T01:49:15Z

Landed in ec0dd6f

Refs: nodejs#31167 PR-URL: nodejs#31675 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Notable changes: * (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](#31166) * (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](#28396) * (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](#31164) * (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](#31167) * (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell) [#31169](#31169) * (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](#32116) * (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](#31165) * (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](#32232) * (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](#32499) * (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps) [#32454](#32454) * (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](#31954) * (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](#32116) PR-URL: #32181

- (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](#31166) - (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](#28396) - (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](#31164) - (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](#31167) - (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell)[#31169](#31169) - (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](#32116) - (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](#31165) - (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](#32232) - (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](#32499) - src: migrate to new V8 ArrayBuffer API (Thang Tran) [#30782](#30782) It is possible that this change will impact some native addons using `ArrayBuffer`. - (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps)[#32454](#32454) - (SEMVER-MAJOR) doc: update cross compiler machine for Linux armv7 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: update Centos/RHEL releases use devtoolset-8 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: remove SmartOS from official binaries (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](#31954) It is expected that there will be an ABI mismatch on ARM between the Node.js binary and native addons. - [#30786](#30786) - (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](#32116) - cli, report: move --report-on-fatalerror to stable (Colin Ihrig) [#32496](#32496) - deps: upgrade to libuv 1.37.0 (Colin Ihrig) [#32866](#32866) - fs: add fs/promises alias module (Gus Caplan) [#31553](#31553) - module: remove experimental modules warning (Guy Bedford) [#31974](#31974) PR-URL: #32181

Deprecations: - (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](#31166) - (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](#28396) - (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](#31164) - (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](#31167) - (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell)[#31169](#31169) - (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](#32116) - (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](#31165) - (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](#32232) - (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](#32499) ECMAScript Modules - Experimental Warning Removal: - module: remove experimental modules warning (Guy Bedford) [#31974](#31974) In Node.js 13 we removed the need to include the --experimental-modules flag, but when running EcmaScript Modules in Node.js, this would still result in a warning ExperimentalWarning: The ESM module loader is experimental. As of Node.js 14 there is no longer this warning when using ESM in Node.js. However, the ESM implementation in Node.js remains experimental. As per our stability index: “The feature is not subject to Semantic Versioning rules. Non-backward compatible changes or removal may occur in any future release.” Users should be cautious when using the feature in production environments. Please keep in mind that the implementation of ESM in Node.js differs from the developer experience you might be familiar with. Most transpilation workflows support features such as optional file extensions or JSON modules that the Node.js ESM implementation does not support. It is highly likely that modules from transpiled environments will require a certain degree of refactoring to work in Node.js. It is worth mentioning that many of our design decisions were made with two primary goals. Spec compliance and Web Compatibility. It is our belief that the current implementation offers a future proof model to authoring ESM modules that paves the path to Universal JavaScript. Please read more in our documentation. The ESM implementation in Node.js is still experimental but we do believe that we are getting very close to being able to call ESM in Node.js “stable”. Removing the warning is a huge step in that direction. Migrate to new V8 ArrayBuffer API: - src: migrate to new V8 ArrayBuffer API (Thang Tran) [#30782](#30782) It is possible that this change will impact some native addons using `ArrayBuffer`. Toolchain and Compiler Upgrades: - (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps)[#32454](#32454) - (SEMVER-MAJOR) doc: update cross compiler machine for Linux armv7 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: update Centos/RHEL releases use devtoolset-8 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: remove SmartOS from official binaries (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](#31954) It is expected that there will be an ABI mismatch on ARM between the Node.js binary and native addons. Native addons are only broken if they interact with `std::shared_ptr`. This is expected to be fixed in a later version of Node.js 14. - [#30786](#30786) Update to V8 8.1: - (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](#32116) Other Notable Changes: - cli, report: move --report-on-fatalerror to stable (Colin Ihrig) [#32496](#32496) - deps: upgrade to libuv 1.37.0 (Colin Ihrig) [#32866](#32866) - fs: add fs/promises alias module (Gus Caplan) [#31553](#31553) PR-URL: #32181

Deprecations: - (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](#31166) - (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](#28396) - (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](#31164) - (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](#31167) - (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell)[#31169](#31169) - (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](#32116) - (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](#31165) - (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](#32232) - (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](#32499) ECMAScript Modules - Experimental Warning Removal: - module: remove experimental modules warning (Guy Bedford) [#31974](#31974) In Node.js 13 we removed the need to include the --experimental-modules flag, but when running EcmaScript Modules in Node.js, this would still result in a warning ExperimentalWarning: The ESM module loader is experimental. As of Node.js 14 there is no longer this warning when using ESM in Node.js. However, the ESM implementation in Node.js remains experimental. As per our stability index: “The feature is not subject to Semantic Versioning rules. Non-backward compatible changes or removal may occur in any future release.” Users should be cautious when using the feature in production environments. Please keep in mind that the implementation of ESM in Node.js differs from the developer experience you might be familiar with. Most transpilation workflows support features such as optional file extensions or JSON modules that the Node.js ESM implementation does not support. It is highly likely that modules from transpiled environments will require a certain degree of refactoring to work in Node.js. It is worth mentioning that many of our design decisions were made with two primary goals. Spec compliance and Web Compatibility. It is our belief that the current implementation offers a future proof model to authoring ESM modules that paves the path to Universal JavaScript. Please read more in our documentation. The ESM implementation in Node.js is still experimental but we do believe that we are getting very close to being able to call ESM in Node.js “stable”. Removing the warning is a huge step in that direction. New V8 ArrayBuffer API: * **src**: migrate to new V8 ArrayBuffer API (Thang Tran) [#30782](#30782) Multiple ArrayBuffers pointing to the same base address are no longer allowed by V8. This may impact native addons. Toolchain and Compiler Upgrades: - (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps)[#32454](#32454) - (SEMVER-MAJOR) doc: update cross compiler machine for Linux armv7 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: update Centos/RHEL releases use devtoolset-8 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: remove SmartOS from official binaries (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](#31954) It is expected that there will be an ABI mismatch on ARM between the Node.js binary and native addons. Native addons are only broken if they interact with `std::shared_ptr`. This is expected to be fixed in a later version of Node.js 14. - [#30786](#30786) Update to V8 8.1: - (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](#32116) Other Notable Changes: - cli, report: move --report-on-fatalerror to stable (Colin Ihrig) [#32496](#32496) - deps: upgrade to libuv 1.37.0 (Colin Ihrig) [#32866](#32866) - fs: add fs/promises alias module (Gus Caplan) [#31553](#31553) PR-URL: #32181

jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Jan 2, 2020

devsnek approved these changes Jan 2, 2020
View reviewed changes

gengjiawen approved these changes Jan 6, 2020
View reviewed changes

BridgeAR mentioned this pull request Jan 6, 2020
Publishing a new release jashkenas/underscore#2819
Closed

Trott reviewed Jan 10, 2020
View reviewed changes

tniessen approved these changes Jan 10, 2020
View reviewed changes

BridgeAR approved these changes Jan 11, 2020
View reviewed changes

jasnell added 2 commits February 3, 2020 08:41

lib: move GLOBAL and root aliases to EOL
e9d1609
GLOBAL and root have been long deprecated.

fixup! lib: move GLOBAL and root aliases to EOL
0d9249a

jasnell force-pushed the eol-DEP0016 branch from 43ee71f to 0d9249aCompare February 3, 2020 16:46

targos approved these changes Feb 3, 2020
View reviewed changes

jasnell added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Feb 4, 2020

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2020

danbev approved these changes Feb 5, 2020
View reviewed changes

mcollina approved these changes Feb 5, 2020
View reviewed changes

jasnell closed this Feb 6, 2020

BethGriggs mentioned this pull request Mar 10, 2020
2020-04-21, Version 14.0.0 (Current) #32181
Merged

Uh oh!

lib: move GLOBAL and root aliases to EOL#31167

lib: move GLOBAL and root aliases to EOL #31167

Uh oh!

Conversation

jasnell commented Jan 2, 2020

Checklist

Uh oh!

Trott commented Jan 2, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Jan 2, 2020

Uh oh!

addaleax commented Jan 3, 2020

Uh oh!

Trott commented Jan 6, 2020

Uh oh!

jashkenas commented Jan 6, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Jan 9, 2020

Uh oh!

TrottJan 10, 2020

Choose a reason for hiding this comment

Uh oh!

jasnell commented Feb 3, 2020

Uh oh!

jasnell commented Feb 3, 2020

Uh oh!

jasnell commented Feb 4, 2020

Uh oh!

Trott commented Feb 4, 2020

Uh oh!

nodejs-github-bot commented Feb 4, 2020

Uh oh!

jasnell commented Feb 4, 2020

Uh oh!

nodejs-github-bot commented Feb 4, 2020

Uh oh!

jasnell commented Feb 4, 2020

Uh oh!

jasnell commented Feb 5, 2020

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Feb 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Trott commented Jan 2, 2020•
edited
Loading

jashkenas commented Jan 6, 2020•
edited
Loading