Skip to content

http2: set default enableConnectProtocol to 0#31174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ZYSzys wants to merge 2 commits into from
Closed

http2: set default enableConnectProtocol to 0 #31174

ZYSzys wants to merge 2 commits into from

Conversation

@ZYSzys
Copy link
Member

@ZYSzysZYSzys commented Jan 3, 2020

According to rfc8441:

9.1. A New HTTP/2 Setting This document registers an entry in the "HTTP/2 Settings" registry that was established by Section 11.3 of [RFC7540]. Code: 0x8 Name: SETTINGS_ENABLE_CONNECT_PROTOCOL Initial Value: 0 Specification: This document

The initial value of SETTINGS_ENABLE_CONNECT_PROTOCOL is 0, so added DEFAULT_SETTINGS_ENABLE_CONNECT_PROTOCOL, and we can access this using http2.getDefaultSettings():

>http2.getDefaultSettings()[Object: nullprototype]{headerTableSize: 4096,enablePush: true,initialWindowSize: 65535,maxFrameSize: 16384,maxConcurrentStreams: 4294967295,maxHeaderListSize: 65535,enableConnectProtocol: false}

Refs: rfc8441

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 3, 2020
@ZYSzysZYSzys added the http2 Issues or PRs related to the http2 subsystem. label Jan 3, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 3, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28207/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28213/

@Trott
Copy link
Member

Trott commented Jan 6, 2020

Landed in 66310c2

@TrottTrott closed this Jan 6, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 6, 2020
@ZYSzys@Trott
http2: set default enableConnectProtocol to 0
66310c2
PR-URL: nodejs#31174 Refs: https://tools.ietf.org/html/rfc8441#section-9.1 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@ZYSzysZYSzys deleted the http2-enable-connect-protocol branch January 6, 2020 05:01
targos pushed a commit that referenced this pull request Jan 6, 2020
@ZYSzys@targos
http2: set default enableConnectProtocol to 0
b5a71a4
PR-URL: #31174 Refs: https://tools.ietf.org/html/rfc8441#section-9.1 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@ZYSzys@targos
http2: set default enableConnectProtocol to 0
5076c59
PR-URL: #31174 Refs: https://tools.ietf.org/html/rfc8441#section-9.1 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
@ZYSzys@targos
http2: set default enableConnectProtocol to 0
20a8175
PR-URL: #31174 Refs: https://tools.ietf.org/html/rfc8441#section-9.1 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@ZYSzys@BethGriggs
http2: set default enableConnectProtocol to 0
5dd7c92
PR-URL: #31174 Refs: https://tools.ietf.org/html/rfc8441#section-9.1 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZYSzys@nodejs-github-bot@Trott@jasnell@cjihrig@BridgeAR