Speed up promise introspection#3130
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
thefourtheye commented Sep 30, 2015
LGTM |
Member
There was a problem hiding this comment.
To prepare the ground for the use of MakeMirror in #3119, may I suggest to move this to a separate function ? setupDebugObjects() for example.
Contributor
evanlucas commented Sep 30, 2015
LGTM |
Use V8's builtin ObjectIsPromise() to check that the value is a promise before creating the promise mirror. Reduces garbage collector strain in the (common) non-promise case, which is beneficial when inspecting deep object graphs. PR-URL: nodejs#3130 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Backport f78215962bf5de9d47c022e7baa3952d0bf6d17f from V8's upstream to speed up promise introspection. Original commit message: Remove obsolete try/catch from ObjectIsPromise(). Review URL: https://codereview.chromium.org/1367123003 Cr-Commit-Position: refs/heads/master@{nodejs#30966} PR-URL: nodejs#3130 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
bnoordhuisforce-pushed the speed-up-promise-introspection branch from 076dd53 to dbe4844CompareMemberAuthor
bnoordhuis commented Sep 30, 2015
Contributor
thefourtheye commented Oct 1, 2015
Ben, can you please link the until commit as well? |
MemberAuthor
bnoordhuis commented Oct 1, 2015
The what now? You mean the original commit? That's bnoordhuis/node@bdfee10 but that's dead now. EDIT: bnoordhuis/io.js@bdfee10 works though. |
Contributor
thefourtheye commented Oct 1, 2015
Sorry I meant the util changes. Damn autocorrect :D |
MemberAuthor
bnoordhuis commented Oct 1, 2015
Ah, sure. That's 3f62c40...dbe4844. |
Contributor
thefourtheye commented Oct 1, 2015
Thanks :-) |
bnoordhuis added a commit that referenced this pull request Oct 2, 2015
Use V8's builtin ObjectIsPromise() to check that the value is a promise before creating the promise mirror. Reduces garbage collector strain in the (common) non-promise case, which is beneficial when inspecting deep object graphs. PR-URL: #3130 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
bnoordhuis added a commit that referenced this pull request Oct 2, 2015
Backport f78215962bf5de9d47c022e7baa3952d0bf6d17f from V8's upstream to speed up promise introspection. Original commit message: Remove obsolete try/catch from ObjectIsPromise(). Review URL: https://codereview.chromium.org/1367123003 Cr-Commit-Position: refs/heads/master@{#30966} PR-URL: #3130 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Member
rvagg commented Oct 5, 2015
is this being upstreamed? do we have an external link or something? |
Member
targos commented Oct 5, 2015
Member
rvagg commented Oct 5, 2015
derp, I see it in the commit msgs now f782159 |
rvagg added a commit that referenced this pull request Oct 5, 2015
Notable changes * http: - Fix out-of-order 'finish' event bug in pipelining that can abort execution, fixes DoS vulnerability CVE-2015-7384 (Fedor Indutny) #3128 - Account for pending response data instead of just the data on the current request to decide whether pause the socket or not (Fedor Indutny) #3128 * libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details (Saúl Ibarra Corretgé) #3010 - A better rwlock implementation for all Windows versions - Improved AIX support * v8: - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) #3117 - Backported f782159 from v8's upstream to help speed up Promise introspection (Ben Noordhuis) #3130 - Backported c281c15 from v8's upstream to add JSTypedArray length in post-mortem metadata (Julien Gilli) #3031 PR-URL: #3128
rvagg added a commit that referenced this pull request Oct 5, 2015
Notable changes * http: - Fix out-of-order 'finish' event bug in pipelining that can abort execution, fixes DoS vulnerability CVE-2015-7384 (Fedor Indutny) #3128 - Account for pending response data instead of just the data on the current request to decide whether pause the socket or not (Fedor Indutny) #3128 * libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details (Saúl Ibarra Corretgé) #3010 - A better rwlock implementation for all Windows versions - Improved AIX support * v8: - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) #3117 - Backported f782159 from v8's upstream to help speed up Promise introspection (Ben Noordhuis) #3130 - Backported c281c15 from v8's upstream to add JSTypedArray length in post-mortem metadata (Julien Gilli) #3031 PR-URL: #3128
ChALkeR added the performance Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@vkurchatkin | @thefourtheye | @targos?
#3107 for background. I realized we don't have to wait for a V8 upgrade.
CI: https://ci.nodejs.org/job/node-test-pull-request/399/