tools: update ESLint to 7.0.0-alpha.2#31400
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
Trott commented Jan 17, 2020
Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that? |
ContributorAuthor
cjihrig commented Jan 17, 2020
I'm fine with that approach. FWIW, in the past, we have updated to ESLint alpha releases as well. |
BridgeAR approved these changes Jan 20, 2020
Member
BridgeAR left a comment
BridgeAR left a comment There was a problem hiding this comment.
RSLGTM
Landing the updates incrementally allows us to adjust everything during the individual release and we could already use the changed features. The eslints changes are normally very stable, no matter that it's an alpha. I am fine with waiting or landing it right away therefore.
BridgeAR added the author ready 
Trott approved these changes Jan 21, 2020
cjihrig changed the title 
Update ESLint to 7.0.0-alpha.0
Update ESLint to 7.0.0-alpha.1
Update ESLint to 7.0.0-alpha.2
cjihrig changed the title 
This comment has been minimized.
This comment has been minimized.
Collaborator
addaleax pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.0 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.1 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
addaleax commented Mar 11, 2020
Landed in 61f28fb...4f87b4f |
addaleax pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.2 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.0 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.1 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.2 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
Update ESLint to 7.0.0-alpha.0 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
Update ESLint to 7.0.0-alpha.1 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
Update ESLint to 7.0.0-alpha.2 PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #31400 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint to 7.0.0-alpha.2
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes