fs: return first folder made by mkdir recursive#31530

bcoe · 2020-01-27T07:30:08Z

mkdir('/foo/bar',{recursive: true }) and mkdirSync will now return
the path of the first folder created. This matches more closely
mkdirp's behavior, and is useful for setting folder permissions.

Refs: #31481

@isaacs mind testing out this branch and seeing if it matches the functionality you were asking for, i.e., populating the path appropriately.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-01-27T20:28:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28719/

bcoe · 2020-01-27T21:40:21Z

@joaocgreis any thoughts on this one, the Windows tests seem to have added a strange prefix to the path I return, ////?; The path looks otherwise correct.

jasnell

LGTM as a semver-minor. Since there was not previously a return value, adding a return value shouldn't be breaking. Docs likely need to be updated also, however.

jasnell · 2020-01-27T21:52:05Z

the Windows tests seem to have added a strange prefix to the path I return, ////?

That's coming from the use of toNamespacedPath() in the path module (https://github.com/nodejs/node/blob/master/lib/path.js#L549). Generally, you'll want to reverse what that module is adding.

src/inspector_profiler.cc

src/node_file-inl.h

src/node_file.cc

src/node_file.h

src/node_file.cc

mkdir('/foo/bar',{recursive: true }) and mkdirSync will now return the path of the first folder created. This matches more closely mkdirp's behavior, and is useful for setting folder permissions. Refs: nodejs#31481

nodejs-github-bot · 2020-01-31T17:33:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28809/ ✔️

MylesBorins · 2020-03-09T16:01:51Z

hey @bcoe do we want to backport this to 13.x?

mkdir('/foo/bar',{recursive: true }) and mkdirSync will now return the path of the first folder created. This matches more closely mkdirp's behavior, and is useful for setting folder permissions. PR-URL: #31530 Refs: #31481 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>

MylesBorins · 2020-03-10T22:22:37Z

After some other backports landed I was able to get this to land with minimal changes 🎉

Notable changes: * [[`ff58854dbe`](ff58854dbe)] - **(SEMVER-MINOR)** **fs**: return first folder made by mkdir recursive (Benjamin Coe) [#31530](#31530) * [[`258a80d3cc`](258a80d3cc)] - **(SEMVER-MINOR)** **src**: create a getter for kernel version (Juan José Arboleda) [#31732](#31732) * [[`4d5981be96`](4d5981be96)] - **(SEMVER-MINOR)** **async_hooks**: add sync enterWith to ALS (Stephen Belanger) [#31945](#31945) * [[`dd83bd266d`](dd83bd266d)] - **(SEMVER-MINOR)** **wasi**: add returnOnExit option (Colin Ihrig) [#32101](#32101) PR-URL: #32185

Notable changes: * async_hooks: - add sync enterWith to ALS (Stephen Belanger) #31945 * cli: - allow --jitless V8 flag in NODE\_OPTIONS (Andrew Neitsch) #32100 * fs: - return first folder made by mkdir recursive (Benjamin Coe) #31530 * n-api: - define release 6 (Gabriel Schulhof) #32058 * src: - create a getter for kernel version (Juan José Arboleda) #31732 * wasi: - add returnOnExit option (Colin Ihrig) #32101 PR-URL: #32185

coreyfarrell · 2020-03-12T11:48:44Z

Will this get backported to 10 or 12 after the two week delay?

Refs: nodejs#31530

addaleax · 2020-03-25T20:05:07Z

If this is backported to v12.x, please include #32490 (with REPLACEME as the version in the backport…)

Refs: #31530 PR-URL: #32490 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

mkdir('/foo/bar',{recursive: true }) and mkdirSync will now return the path of the first folder created. This matches more closely mkdirp's behavior, and is useful for setting folder permissions. PR-URL: nodejs#31530 Refs: nodejs#31481 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: nodejs#31530 PR-URL: nodejs#32490 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

mkdir('/foo/bar',{recursive: true }) and mkdirSync will now return the path of the first folder created. This matches more closely mkdirp's behavior, and is useful for setting folder permissions. PR-URL: #31530 Refs: #31481 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #31530 PR-URL: #32490 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

bcoe added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 27, 2020

bcoe requested review from BridgeAR, Trott and addaleax January 27, 2020 07:30

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 27, 2020

jasnell approved these changes Jan 27, 2020
View reviewed changes

bcoe added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Jan 27, 2020

This comment has been minimized.
Sign in to view

addaleax approved these changes Jan 28, 2020
View reviewed changes

Trott approved these changes Jan 29, 2020
View reviewed changes

fs: return first folder made by mkdir recursive
e865d43
mkdir('/foo/bar',{recursive: true }) and mkdirSync will now return the path of the first folder created. This matches more closely mkdirp's behavior, and is useful for setting folder permissions. Refs: nodejs#31481

bcoe force-pushed the mkdirp-return branch from 4513a05 to e865d43Compare January 29, 2020 07:18

chore: we no longer used replace_substring
695bb57

This comment has been minimized.
Sign in to view

Benjamin Coe added 3 commits January 30, 2020 11:14

fix: add missing semicolon
004e480

fix: pass by reference logic
b5cd988

chore: fix windows bugs and linting
cfc6bd5

This comment has been minimized.
Sign in to view

MylesBorins removed the backport-requested-v13.x label Mar 10, 2020

MylesBorins mentioned this pull request Mar 10, 2020
v13.11.0 proposal #32185
Merged

addaleax added a commit to addaleax/node that referenced this pull request Mar 25, 2020
doc: add missing changes: entry for mkdir
e91a07f
Refs: nodejs#31530

addaleax mentioned this pull request Mar 25, 2020
doc: add missing changes: entry for mkdir #32490
Closed
3 tasks

targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020

targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged

meixg mentioned this pull request Mar 3, 2023
fs:mkdir should return path not undefined #46915
Closed

Uh oh!

fs: return first folder made by mkdir recursive#31530

fs: return first folder made by mkdir recursive #31530

Uh oh!

Conversation

bcoe commented Jan 27, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Jan 27, 2020

Uh oh!

bcoe commented Jan 27, 2020

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Jan 27, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Jan 31, 2020• edited by bcoe Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MylesBorins commented Mar 9, 2020

Uh oh!

MylesBorins commented Mar 10, 2020

Uh oh!

coreyfarrell commented Mar 12, 2020

Uh oh!

addaleax commented Mar 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

bcoe commented Jan 27, 2020•
edited
Loading

nodejs-github-bot commented Jan 31, 2020•
edited by bcoe
Loading