[v10.x-staging] v8: fix load elimination liveness checks#31613
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit back-ports the implementations of IsRename() and MayAlias() from the upstream 8.0 branch wholesale. Fixes several bugs where V8's load elimination pass considered values to be alive when they weren't. Fixes: nodejs#31484
nodejs-github-bot added v10.x v8 engine 
Collaborator
nodejs-github-bot commented Feb 2, 2020
MemberAuthor
https://ci.nodejs.org/job/node-test-commit-v8-linux/2835/ - although previous runs suggest the V8 in v10.x doesn't build standalone on all buildbots anymore. To be clear: not caused by this PR. https://ci.nodejs.org/job/node-test-commit-v8-linux/2836/ - v10.x-staging, for comparison. |
jasnell approved these changes Feb 3, 2020
bnoordhuis added the author ready 
BethGriggs approved these changes Feb 25, 2020
BethGriggs pushed a commit that referenced this pull request Feb 26, 2020
This commit back-ports the implementations of IsRename() and MayAlias() from the upstream 8.0 branch wholesale. Fixes several bugs where V8's load elimination pass considered values to be alive when they weren't. Fixes: #31484 PR-URL: #31613 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Member
BethGriggs commented Feb 26, 2020
Landed in dc61e09 |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit back-ports the implementations of IsRename() and MayAlias()
from the upstream 8.0 branch wholesale. Fixes several bugs where V8's
load elimination pass considered values to be alive when they weren't.
Fixes: #31484
Supersedes #31507.