doc: add method links in events.markdown#3187
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added doc 
doc/api/events.markdown Outdated
Contributor
silverwind commented Oct 11, 2015
ping @a0viedo |
Member
jasnell commented Nov 5, 2015
@a0viedo ... is this still a change you'd like to see made? |
MemberAuthor
a0viedo commented Nov 5, 2015
Sorry for leaving this stranded. Updated the reference that @silverwind pointed out. Also, would love your feedback of future doc changes @jasnell: would be best to group future changes (in different modules) in a single PR? |
Contributor
silverwind commented Nov 5, 2015
LGTM |
Member
jasnell commented Nov 5, 2015
LGTM. @a0viedo ... I'm happy with it either way, really. I know some prefer to see a fewer number of PRs with more changes, others prefer PRs to be more focused. |
doc/api/events.markdown Outdated
Member
There was a problem hiding this comment.
while you are editing this line, could you please fix fs.ReadStream (capital R) ?
Member
targos commented Nov 5, 2015
LGTM with one comment, but that can be taken care of while landing. |
Added referenced method links.
targos pushed a commit that referenced this pull request Nov 6, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Member
targos commented Nov 6, 2015
Thanks. Landed in d26927c with an edit to fit 80 characters/line. |
rvagg pushed a commit that referenced this pull request Nov 7, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Contributor
MylesBorins commented Nov 16, 2015
landed in lts-v4.x-staging as 22bfe22 |
rvagg pushed a commit that referenced this pull request Dec 4, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Closed
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added referenced method links.