async_hooks: avoid resource reuse by FileHandle#31972
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
addaleax approved these changes Feb 26, 2020
devnexen approved these changes Feb 27, 2020
jasnell approved these changes Feb 27, 2020
Qard approved these changes Mar 2, 2020
BridgeAR added the author ready 
Collaborator
nodejs-github-bot commented Mar 9, 2020
MemberAuthor
Flarna commented Mar 9, 2020
Seems like something committed since my last commit caused the test to fail. will take a look... |
Flarna changed the title MemberAuthor
Flarna commented Mar 9, 2020
Wrap reused read_wrap in a unique async resource to ensure that executionAsyncResource() is not ambiguous.
Flarnaforce-pushed the async-hooks-streampipe-reuse branch from eaf051f to 6e677daCompareMemberAuthor
Flarna commented Mar 10, 2020
Rebased and change to a larger fixture. Seems #31869 caused that less fileIO operations are done (2 instead 3). Using a larger fixture ensures that enough file io is done for the testcase. |
Flarna changed the title addaleax approved these changes Mar 10, 2020
Collaborator
nodejs-github-bot commented Mar 11, 2020
Member
addaleax commented Mar 11, 2020
Landed in c145b29 |
addaleax pushed a commit that referenced this pull request Mar 11, 2020
Wrap reused read_wrap in a unique async resource to ensure that executionAsyncResource() is not ambiguous. PR-URL: #31972 Refs: #30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Wrap reused read_wrap in a unique async resource to ensure that executionAsyncResource() is not ambiguous. PR-URL: #31972 Refs: #30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Merged
2 tasks
cjihrig added a commit to cjihrig/node that referenced this pull request Mar 15, 2020
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: nodejs#32241 Refs: nodejs#31972 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: #32241 Refs: #31972 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: #32241 Refs: #31972 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
Wrap reused read_wrap in a unique async resource to ensure that executionAsyncResource() is not ambiguous. PR-URL: #31972 Refs: #30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: #32241 Refs: #31972 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap reused read_wrap in a unique async resource to ensure that
executionAsyncResource()is not ambiguous.Refs: #30959
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes