stream: make stream.destroy with callback API public#32021
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
stream.destroy(err, callback)API public.Additionally it makes some changes:
always(see TODO) invoked with the same behavior as eossuppressed.
The callback timing is the same regardless whether destroy(see TODO)has already been called or not.
The callback used to be invoked before emitting 'error' and/or(see TODO)'close'.
Also fixes a bug for
fsstreams where the callback toclose(cb)could either be invoked synchronously or before the stream was actually closed. Likewise during errored destruction with implementations that use stream commonswriteGeneric.This is made possible by #31509
This affects a non-public API which is used internally at the following locations:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes