test: add coverage for FSWatcher exception#32057
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
4 tasks
Collaborator
nodejs-github-bot commented Mar 3, 2020
MemberAuthor
Trott commented Mar 3, 2020
@nodejs/testing |
MemberAuthor
Trott commented Mar 4, 2020
@nodejs/fs |
MemberAuthor
Trott commented Mar 4, 2020
This could use a review or two. @nodejs/collaborators |
lpinca approved these changes Mar 4, 2020
Trott added the author ready 
antsmartian approved these changes Mar 5, 2020
Trott added a commit to Trott/io.js that referenced this pull request Mar 5, 2020
Remove convenience function for internal assertions. It is only used once. Signed-off-by: Rich Trott <[email protected]> PR-URL: nodejs#32057 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 5, 2020
Cover an previously uncovered exception possible in the internal start function for FSWatcher. Signed-off-by: Rich Trott <[email protected]> PR-URL: nodejs#32057 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
MemberAuthor
Trott commented Mar 5, 2020
Landed in 757e203...b1d4c13 |
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
Remove convenience function for internal assertions. It is only used once. Signed-off-by: Rich Trott <[email protected]> PR-URL: #32057 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
Cover an previously uncovered exception possible in the internal start function for FSWatcher. Signed-off-by: Rich Trott <[email protected]> PR-URL: #32057 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Merged
Member
codebytere commented Mar 16, 2020
@Trott is this applicable to |
MemberAuthor
Trott commented Mar 16, 2020
This just adds some test coverage and is inessential, so I think |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover an previously uncovered exception possible in the internal start
function for FSWatcher.
While at it, remove convenience function for internal assertions from testing common module. It is only used once.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes