doc: improve Buffer documentation#32086
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Various improvements to the Buffer docs.
nodejs-github-bot added buffer 
jasnell approved these changes Mar 4, 2020
MemberAuthor
addaleax commented Mar 7, 2020
@jasnell I’ve updated this based on feedback I’ve received in private, feel free to take another look :) |
addaleaxforce-pushed the buffer-doc-rewrite branch from cb995aa to 8cc28abCompareMemberAuthor
addaleax commented Mar 10, 2020
@nodejs/documentation |
Member
jasnell commented Mar 10, 2020
Still LGTM |
addaleax added the author ready MemberAuthor
addaleax commented Mar 11, 2020
Landed in c41e360 |
addaleax added a commit that referenced this pull request Mar 11, 2020
Various improvements to the Buffer docs. PR-URL: #32086 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Various improvements to the Buffer docs. PR-URL: #32086 Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
Various improvements to the Buffer docs. PR-URL: #32086 Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various improvements to the Buffer docs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes