Skip to content

Conversation

@lundibundi
Copy link
Member

Fixes: #20605
Refs: libuv/libuv#1837

/cc @richardlau @nodejs/platform-windows @nodejs/documentation @nodejs/child_process

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Mar 4, 2020
bzoz
bzoz approved these changes Mar 5, 2020
Copy link
Contributor

@bzozbzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

@lundibundilundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2020
@addaleax
Copy link
Member

Landed in 4b84010

addaleax pushed a commit that referenced this pull request Mar 11, 2020
Fixes: #20605 Refs: libuv/libuv#1837 PR-URL: #32091 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Fixes: #20605 Refs: libuv/libuv#1837 PR-URL: #32091 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Fixes: #20605 Refs: libuv/libuv#1837 PR-URL: #32091 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Mar 12, 2020
targos pushed a commit that referenced this pull request Apr 22, 2020
Fixes: #20605 Refs: libuv/libuv#1837 PR-URL: #32091 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@targostargos mentioned this pull request Apr 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.child_processIssues and PRs related to the child_process subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Questionable internal casing of property name process.env.Path

7 participants

@lundibundi@addaleax@lpinca@richardlau@BridgeAR@bzoz@nodejs-github-bot