Skip to content

src: fix compiler warnings#32126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjihrig merged 2 commits into from
Mar 8, 2020
Merged

src: fix compiler warnings #32126

cjihrig merged 2 commits into from
Mar 8, 2020

Conversation

@cjihrig
Copy link
Contributor

@cjihrigcjihrig commented Mar 6, 2020

Refs: #32069

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 6, 2020
mhdawson
mhdawson approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 6, 2020•
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29593/ 💛

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2020
@cjihrig
src: fix -Winconsistent-missing-override warning
3b8d70d
../src/node_http_common.h:497:8: warning: 'MemoryInfo' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void MemoryInfo(MemoryTracker* tracker) const{PR-URL: nodejs#32126 Refs: nodejs#32069 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@cjihrig
src: fix -Wreorder compiler warning
7bb4f95
../src/node_http_common-inl.h:126:7: warning: field 'token_' will be initialized after field 'name_' [-Wreorder] : token_(other.token_), PR-URL: nodejs#32126 Refs: nodejs#32069 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@cjihrigcjihrig merged commit 7bb4f95 into nodejs:masterMar 8, 2020
@cjihrig
Copy link
ContributorAuthor

cjihrig commented Mar 8, 2020

Landed in 99e5725...7bb4f95.

@cjihrigcjihrig deleted the warnings branch March 8, 2020 19:18
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@cjihrig@MylesBorins
src: fix -Winconsistent-missing-override warning
7b9b578
../src/node_http_common.h:497:8: warning: 'MemoryInfo' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void MemoryInfo(MemoryTracker* tracker) const{PR-URL: #32126 Refs: #32069 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@cjihrig@MylesBorins
src: fix -Wreorder compiler warning
e9f9d07
../src/node_http_common-inl.h:126:7: warning: field 'token_' will be initialized after field 'name_' [-Wreorder] : token_(other.token_), PR-URL: #32126 Refs: #32069 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Mar 10, 2020
Merged
@codebytere
Copy link
Member

codebytere commented Mar 16, 2020

This is blocked for v12.x pending landing of #32069.

@targostargos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@tniessentniessentniessen approved these changes

@richardlaurichardlaurichardlau approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

+2 more reviewers

@devnexendevnexendevnexen approved these changes

@lundibundilundibundilundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@cjihrig@nodejs-github-bot@codebytere@addaleax@lpinca@tniessen@devnexen@richardlau@lundibundi@mhdawson@targos