build: workaround for gclient python3 issues

[mmarchini]

gclient doesn't support Python 3 yet. To workaround that problem, add an
enviroment variable to override the Python version used by ./configure.

Signed-off-by: Matheus Marchini [email protected]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[rvagg]

cc @nodejs/python

[cclauss]

Do we really need to rely on gclient? If it was a production worthy tool, surely it would have been upgraded by now.

[BridgeAR]

Just looking at a recent gclient commit, it seems that Python 3 is now supported?

[mmarchini]

Do we really need to rely on gclient? If it was a production worthy tool, surely it would have been upgraded by now.

Yes, gclient is the only supported way to build V8. The alternative would be for us to maintain gyp files for V8 tests as well, which is not worth it.

Just looking at a recent gclient commit, it seems that Python 3 is now supported?

Oh, nice. Python 3 support is behind an environment variable apparently. Let me test locally (but I think it never failed locally for me, so maybe there's also a problem in our CI, in which case I would rather land this to unbreak the CI and investigate the issue further later).

[mmarchini]

V8 CI for this PR: https://ci.nodejs.org/job/node-test-commit-v8-linux/2928/

V8 CI with GCLIENT_PY3: https://ci.nodejs.org/job/node-test-commit-v8-linux/2931/

V8 CI on canary-base with GCLIENT_PY3: https://ci.nodejs.org/job/node-test-commit-v8-linux/2932/

[targos]

I was just able to run gclient sync on my V8 clone and I do not have Python 2 installed on my machine.

[mmarchini]

Still failing, even though gclient doesn't complain about Python 3 with the environment variable set.

07:43:05 Failed to fetch file gs://chromium-clang-format/942fc8b1789144b8071d3fc03ff0fcbe1cf81ac8 for v8/buildtools/linux64/clang-format. [Err: gsutil requires python 2.6 or 2.7. 07:43:05 ] 07:43:05 0> Failed to fetch file gs://chromium-clang-format/942fc8b1789144b8071d3fc03ff0fcbe1cf81ac8 for v8/buildtools/linux64/clang-format, skipping. [Err: gsutil requires python 2.6 or 2.7. 07:43:05 ] 07:43:05 Downloading 1 files took 4.206573 second(s) 07:43:05 Error: Command 'download_from_google_storage --no_resume --platform=linux* --no_auth --bucket chromium-clang-format -s v8/buildtools/linux64/clang-format.sha1' returned non-zero exit status 1 in . 

I'm running one with GCLIENT_PY3 on top of canary-base, but I expect the same failure.

I think there's something else wrong in our CI. But investigating it will probably take time, so I'm still in favor of landing this PR to unbreak our CI.

[mmarchini]

Landed in de8fab9