test: mark test-timers-blocking-callback flaky on osx#32189
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: nodejs#21781
ContributorAuthor
MylesBorins commented Mar 11, 2020
Can I get a fastrack? this is going to block 13.11.0 |
MylesBorins added the fast-track 
gireeshpunathil approved these changes Mar 11, 2020
BethGriggs approved these changes Mar 11, 2020
ContributorAuthor
MylesBorins commented Mar 11, 2020
landed in e00e77e |
MylesBorins added a commit that referenced this pull request Mar 11, 2020
This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: #21781 PR-URL: #32189 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
MylesBorins added a commit that referenced this pull request Mar 11, 2020
This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: #21781 PR-URL: #32189 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: #21781 PR-URL: #32189 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only for 10.15 but this test is periodically failing across
many CI runs. Would like to mark this as flaky so we can avoid lots
of red CI.
Refs: #21781