[v12.x backport] module: drop support for extensionless main entry points in esm#32280
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added esm 
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 4d3b533 to 8e8b655Compare
Collaborator
nodejs-github-bot commented Mar 15, 2020
This comment has been minimized.
This comment has been minimized.
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 8e8b655 to e1a4de2CompareGeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from e1a4de2 to 287ef5fCompareCollaborator
nodejs-github-bot commented Mar 15, 2020
4 tasks
Member
puzpuzpuz commented Mar 15, 2020
I've created #32282 to deal with that. |
bmeck approved these changes Mar 16, 2020
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 287ef5f to 4ee0478Compare
This comment has been minimized.
This comment has been minimized.
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 4ee0478 to 3f31b1aCompareCollaborator
nodejs-github-bot commented Mar 17, 2020
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 3f31b1a to bb4fbbeCompare This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Mar 19, 2020
This comment has been minimized.
This comment has been minimized.
guybedfordforce-pushed the backport-31415-to-12.x-staging branch from bb4fbbe to 3e13dc7CompareCollaborator
nodejs-github-bot commented Mar 23, 2020
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 009d0a2 to 0da01a7CompareCollaborator
nodejs-github-bot commented Mar 24, 2020
MemberAuthor
@codebytere I've been struggling with this for over a week now and I just can't get CI to pass. From what I can tell of the CI jobs that are failing, like When I run locally, I get this error with Perhaps we need to increase the allowable delta here? |
Collaborator
nodejs-github-bot commented Mar 25, 2020
Collaborator
nodejs-github-bot commented Mar 26, 2020
Collaborator
nodejs-github-bot commented Mar 26, 2020
Collaborator
nodejs-github-bot commented Mar 26, 2020
Collaborator
nodejs-github-bot commented Mar 26, 2020
Collaborator
nodejs-github-bot commented Mar 26, 2020
Collaborator
nodejs-github-bot commented Mar 26, 2020
MemberAuthor
GeoffreyBooth commented Mar 26, 2020
@codebytere I keep resuming CI, but Can we land this, since the problem appears to be in the staging branch? |
Contributor
MylesBorins commented Mar 26, 2020
As the failure seems unrelated to this PR and on the staging branch I think this is ok to land @codebytere thoughts? |
Collaborator
nodejs-github-bot commented Mar 26, 2020
Collaborator
nodejs-github-bot commented Mar 26, 2020
codebytereforce-pushed the v12.x-staging branch 2 times, most recently from 63a03d2 to d577190CompareMember
@GeoffreyBooth staging should be good to rebase against, then we can get this landed. |
PR-URL: nodejs#31415 Backport-PR-URL: nodejs#32280 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Rich Trott <[email protected]>
guybedfordforce-pushed the backport-31415-to-12.x-staging branch from 0da01a7 to b6ad757Compare
Contributor
guybedford commented Apr 1, 2020
I've updated the rebase here. |
Collaborator
nodejs-github-bot commented Apr 1, 2020
Collaborator
nodejs-github-bot commented Apr 1, 2020
Collaborator
MylesBorins pushed a commit that referenced this pull request Apr 1, 2020
Backport-PR-URL: #32280 PR-URL: #31415 Backport-PR-URL: #32280 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Contributor
MylesBorins commented Apr 1, 2020
finally green! Landed in 4ee41c5 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #31415. Thank you @codebytere for the prompt!
This isn't as clean as it could be because of 04d07ed. @bmeck or @guybedford do you mind double-checking this? I'm assuming that we don't want to merge into 12 the commit that was reverted.