Skip to content

Conversation

@jasnell
Copy link
Member

@jasnelljasnell commented Mar 19, 2020

This is the second of three separate PRs that would need to be landed together. They have been split to allow easier reviewing. This PR covers the addition of the ngtcp2 and nghttp3 dependencies to the source tree.

NOTE: This PR merges into the initial-quic-part-1 branch

The other two PRs in this batch are:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@sam-github
Copy link
Contributor

This commit has two .gyp files in it, which are unique to Node.js (and have inconsistent indentation, if that matters).

For maintainability, the commit adding the gyp files that we maintain should be split from the commit adding the upstream maintained source.

The commit adding the upstream src should describe where it came from, and what version of the dep got vendored in (probably just a "curled from this URL (that includes a version), untarred, moved into place" is sufficient if it came from a released tarball.

There should be commit adding a doc/guide/maintaining-ngXXX doc (one? two? as you think reasonable) that describes how to update these deps when they inevitably need updating.

@jasnell
Copy link
MemberAuthor

Will work those changes in @sam-github thank you :-)

@jasnelljasnellforce-pushed the initial-quic-part-1 branch from 718a2b7 to 00bfcd9CompareMarch 24, 2020 01:15
@jasnelljasnellforce-pushed the initial-quic-part-2 branch from ae9efc1 to c6cc7d0CompareMarch 24, 2020 01:15
@jasnell
Copy link
MemberAuthor

Updated to include maintenance instructions

@jasnelljasnell added the review wanted PRs that need reviews. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
MemberAuthor

Putting all three of the PRs here on the tsc-agenda to queue up discussion on how we want to get these landed.

@jasnelljasnell added tsc-agenda Issues and PRs to discuss during the meetings of the TSC. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Mar 31, 2020
@jasnelljasnell removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Apr 15, 2020
@jasnelljasnellforce-pushed the initial-quic-part-1 branch from 00bfcd9 to 7afa9a8CompareMay 7, 2020 23:44
@jasnelljasnellforce-pushed the initial-quic-part-2 branch from c6cc7d0 to 88ea645CompareMay 7, 2020 23:45
@jasnell
Copy link
MemberAuthor

nodejs/quic master was rebased and sync'd with nodejs/master earlier today. The commits in the PR have been updated accordingly.

@jasnelljasnellforce-pushed the initial-quic-part-1 branch from 7afa9a8 to 846b216CompareJune 3, 2020 23:35
@jasnelljasnellforce-pushed the initial-quic-part-2 branch from 88ea645 to 28fbb81CompareJune 3, 2020 23:36
Qard
Qard approved these changes Jun 4, 2020
@jasnelljasnellforce-pushed the initial-quic-part-1 branch from 846b216 to 0612442CompareJune 9, 2020 16:22
@jasnelljasnellforce-pushed the initial-quic-part-2 branch from 28fbb81 to 9f13c4fCompareJune 9, 2020 16:22
@jasnelljasnellforce-pushed the initial-quic-part-1 branch from 0612442 to e96bea6CompareJune 16, 2020 16:14
@jasnelljasnellforce-pushed the initial-quic-part-2 branch from 9f13c4f to 813739bCompareJune 16, 2020 16:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quicIssues and PRs related to the QUIC implementation / HTTP/3.review wantedPRs that need reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@sam-github@nodejs-github-bot@Qard@codebytere