[v10.x backport] Openssl 1.1.1e#32443
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the openssl Merged
BethGriggsforce-pushed the v10.20.0-proposal branch from 5f10b71 to 3a9d15fCompare
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz $ mv openssl-1.1.1e openssl $ git add --all openssl $ git commit openssl PR-URL: nodejs#32328Fixes: nodejs#32210 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
The scripts used by make were modified to correctly reference the source files that were originially in crypto/include/internal, but got moved to include/crypto. The base path has been left unaltered since that would require too many changes PR-URL: nodejs#32328Fixes: nodejs#32210 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/include PR-URL: nodejs#32328Fixes: nodejs#32210 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
In openssl-1.1.1e the client doesn't seem to like having the TLS connection shut down with no data sent, so send an empty string. A number of related issues showed up in the TLS1.3 port, so this is not entirely surprising. PR-URL: nodejs#32328Fixes: nodejs#32210 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
sam-githubforce-pushed the openssl-1.1.1e-v10.x branch from 2c9e012 to 647cdb9Compare
Collaborator
nodejs-github-bot commented Mar 23, 2020
Collaborator
BethGriggs approved these changes Mar 24, 2020
Member
BethGriggs commented Mar 24, 2020
ping @nodejs/releasers, @nodejs/lts, I am planning to pull this into v10.20.0, PTAL |
richardlau approved these changes Mar 24, 2020
BethGriggs pushed a commit that referenced this pull request Mar 24, 2020
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz $ mv openssl-1.1.1e openssl $ git add --all openssl $ git commit openssl PR-URL: #32328 Backport-PR-URL: #32443Fixes: #32210 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Mar 24, 2020
The scripts used by make were modified to correctly reference the source files that were originially in crypto/include/internal, but got moved to include/crypto. The base path has been left unaltered since that would require too many changes PR-URL: #32328 Backport-PR-URL: #32443Fixes: #32210 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Mar 24, 2020
After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/include PR-URL: #32328 Backport-PR-URL: #32443Fixes: #32210 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Mar 24, 2020
In openssl-1.1.1e the client doesn't seem to like having the TLS connection shut down with no data sent, so send an empty string. A number of related issues showed up in the TLS1.3 port, so this is not entirely surprising. PR-URL: #32328 Backport-PR-URL: #32443Fixes: #32210 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
BethGriggs commented Mar 24, 2020
Landed in bf26c44...89692ff |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesBackport of #32328