doc: Clarify API Buffer.concat#3255
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Add a simple example. Change grammar slightly. Closes#3219
mscdex added buffer 
doc/api/buffer.markdown Outdated
There was a problem hiding this comment.
But it's not the length of the list, is it? It's the total byte size of all buffers combined if I'm not mistaken.
There was a problem hiding this comment.
perhaps "buffers in the list" would work better?
jasnell commented Oct 14, 2015
LGTM |
seishun commented Oct 15, 2015
I don't think an example is needed. TBH I think the current documentation is fine and the "in the list" part can be inferred. |
jasnell commented Oct 21, 2015
@seishun ... more examples are almost never a bad thing to have in documentation. |
trevnorris commented Oct 22, 2015
I'm cool w/ this. LGTM |
* Add a simple example for buffer.concat * Change grammar slightly. Fixes: #3219 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]> PR-URL: #3255
jasnell commented Oct 22, 2015
Landed in e32aca6. @Martii , I fixed up the commit log just a bit to match the common style. |
MylesBorins commented Oct 23, 2015
should this be in LTS /cc @jasnell |
jasnell commented Oct 23, 2015
@thealphanerd +1
|
Martii commented Oct 23, 2015
@jasnell |
* Add a simple example for buffer.concat * Change grammar slightly. Fixes: #3219 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]> PR-URL: #3255
jasnell commented Oct 26, 2015
Landed in v4.x-staging in 4afcf57 |
* Add a simple example for buffer.concat * Change grammar slightly. Fixes: #3219 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]> PR-URL: #3255
* Add a simple example for buffer.concat * Change grammar slightly. Fixes: #3219 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]> PR-URL: #3255
7 participants
Fixes: #3219