src: initialize inspector before RunBootstrapping()#32672
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ This was referenced Apr 5, 2020
devsnek reviewed Apr 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: nodejs#32648 Refs: nodejs#30467 (comment)
addaleaxforce-pushed the inspector-init-createenvironment branch from 0979bd5 to 4ce0133Comparedevsnek reviewed Apr 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
devsnek approved these changes Apr 5, 2020
MemberAuthor
addaleax commented Apr 5, 2020
@devsnek Sorry, had to make a few changes to get tests to pass (some of which were rather obvious in hindsight) … could you take another look? |
devsnek approved these changes Apr 6, 2020
eugeneo approved these changes Apr 6, 2020
joyeecheung approved these changes Apr 6, 2020
Member
joyeecheung left a comment
joyeecheung left a comment There was a problem hiding this comment.
LGTM. I am still skeptical about whether it's necessary to burden users with maintaining InspectorParentHandle across threads through the Environment API, but it is what it is
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Apr 6, 2020
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/30502/ (:heavy_check_mark:) |
devnexen approved these changes Apr 6, 2020
jasnell approved these changes Apr 7, 2020
MemberAuthor
addaleax commented Apr 7, 2020
Landed in 8aa7ef7 |
addaleax added a commit that referenced this pull request Apr 7, 2020
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: #32648 Refs: #30467 (comment) PR-URL: #32672 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: #32648 Refs: #30467 (comment) PR-URL: #32672 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
richardlau commented Apr 20, 2020
It looks like this PR is making |
4 tasks
addaleax added a commit to addaleax/node that referenced this pull request Sep 23, 2020
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: nodejs#32648 Refs: nodejs#30467 (comment) PR-URL: nodejs#32672 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Sep 23, 2020
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: #32648 Refs: #30467 (comment) Backport-PR-URL: #35241 PR-URL: #32672 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere added a commit to electron/electron that referenced this pull request May 20, 2021
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
codebytere added a commit to electron/electron that referenced this pull request Jun 8, 2021
codebytere added a commit to electron/electron that referenced this pull request Jun 9, 2021
codebytere added a commit to electron/electron that referenced this pull request Jun 10, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for
--inspect-brk-nodeto work, and for theinspector to be aware of scripts created before bootstrapping.
Fixes: #32648
Refs: #30467 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes