stream: cleanup pipeline destroyer#32690
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Slightly cleans up the destroyer logic.
Collaborator
nodejs-github-bot commented Apr 6, 2020
rickyes reviewed Apr 8, 2020
| destroyImpl.destroyer(stream,err); | ||
| if(!err&&!reading&&writing&&stream.readable){ | ||
| returncallback(); | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe merge writable and readable.
Collaborator
nodejs-github-bot commented Apr 10, 2020
Collaborator
4 tasks
ronag added the author ready 
BridgeAR approved these changes Apr 20, 2020
| if(err||!final||!stream.readable){ | ||
| destroyImpl.destroyer(stream,err); | ||
| if(!err&&!reading&&writing&&stream.readable){ |
Member
There was a problem hiding this comment.
if(!err){if(reading){if(!writing&&stream.writable){returncallback();}}elseif(writing&&stream.readable){returncallback();}}ronag added blocked 
MemberAuthor
ronag commented Apr 21, 2020
This might be redundant given #32966 |
MemberAuthor
ronag commented Apr 21, 2020
closed in favor of #32968 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly cleans up the destroyer logic. Make readable and writable use similar logic.
i.e.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes