Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Apr 7, 2020

Split doc entries for process.umask() into one entry for process.umask()
(which is deprecated) and another for process.umask(mask) which is
not deprecated.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 7, 2020
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2020
Split doc entries for process.umask() into one entry for process.umask() (which is deprecated) and another for `process.umask(mask)` which is not deprecated. PR-URL: nodejs#32711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@TrottTrottforce-pushed the umask-comma-splice branch from fcb6a1d to 1535243CompareApril 10, 2020 20:21
@Trott
Copy link
MemberAuthor

Landed in 1535243

@TrottTrott merged commit 1535243 into nodejs:masterApr 10, 2020
@TrottTrott deleted the umask-comma-splice branch April 10, 2020 20:22
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
Split doc entries for process.umask() into one entry for process.umask() (which is deprecated) and another for `process.umask(mask)` which is not deprecated. PR-URL: #32711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Aug 1, 2020
Split doc entries for process.umask() into one entry for process.umask() (which is deprecated) and another for `process.umask(mask)` which is not deprecated. PR-URL: nodejs#32711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 18, 2020
Split doc entries for process.umask() into one entry for process.umask() (which is deprecated) and another for `process.umask(mask)` which is not deprecated. Backport-PR-URL: #34591 PR-URL: #32711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
jimmy54 pushed a commit to jimmy54/nodejs-mobile that referenced this pull request Dec 31, 2025
Split doc entries for process.umask() into one entry for process.umask() (which is deprecated) and another for `process.umask(mask)` which is not deprecated. Backport-PR-URL: nodejs/node#34591 PR-URL: nodejs/node#32711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@jasnell@addaleax@targos@nodejs-github-bot