Skip to content

src: add AliasedStruct utility#32778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasnell wants to merge 4 commits into from
Closed

src: add AliasedStruct utility #32778

jasnell wants to merge 4 commits into from

Conversation

@jasnell
Copy link
Member

@jasnelljasnell commented Apr 11, 2020•
edited
Loading

For http2 (and eventually QUIC) we have a struct that is backed
by a v8::BackingStore and exposed to the JavaScript side as an
ArrayBuffer and TypedArray. This is similar to AliasedBuffer
except that it is fronted by a struct on the C++ side.

structfoo{uint32_t ex1; uint32_t ex2}; AliasedStruct<foo> foo_; foo_->ex1 = 1; foo_->ex2 = 2; foo_.GetArrayBuffer();

Signed-off-by: James M Snell [email protected]

/cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@jasnell
src: add AliasedStruct utility
63c9503
For http2 (and eventually QUIC) we have a struct that is backed by a v8::BackingStore and exposed to the JavaScript side as an ArrayBuffer and TypedArray. This is similar to AliasedBuffer except that it is fronted by a struct on the C++ side. ```c++ struct foo{uint32_t ex1; uint32_t ex2}; AliasedStruct<foo> foo_; foo_->ex1 = 1; foo_->ex2 = 2; foo_.GetArrayBuffer(); ``` Signed-off-by: James M Snell <[email protected]>
@jasnelljasnell added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 11, 2020
@jasnelljasnell requested a review from addaleaxApril 11, 2020 03:21
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 11, 2020
@jasnelljasnell mentioned this pull request Apr 11, 2020
Closed
addaleax
addaleax approved these changes Apr 11, 2020
View reviewed changes
@richardlau
Copy link
Member

richardlau commented Apr 11, 2020

Add a cctest? (We have test/cctest/test_aliased_buffer.cc for AliasedBuffer.)

@addaleax
Copy link
Member

addaleax commented Apr 11, 2020

I don’t think this is the kind of feature that needs to come with a cctest, all of its functionality is basically tested through the existing usage, I’d say.

Flarna
Flarna reviewed Apr 11, 2020
View reviewed changes
Flarna
Flarna reviewed Apr 11, 2020
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 12, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30669/

addaleax
addaleax approved these changes Apr 12, 2020
View reviewed changes
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30688/

addaleax
addaleax reviewed Apr 13, 2020
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30692/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30697/

@addaleax
Copy link
Member

addaleax commented Apr 14, 2020

Landed in cecb08f

addaleax pushed a commit that referenced this pull request Apr 14, 2020
@jasnell@addaleax
src: add AliasedStruct utility
cecb08f
For http2 (and eventually QUIC) we have a struct that is backed by a v8::BackingStore and exposed to the JavaScript side as an ArrayBuffer and TypedArray. This is similar to AliasedBuffer except that it is fronted by a struct on the C++ side. ```c++ struct foo{uint32_t ex1; uint32_t ex2}; AliasedStruct<foo> foo_; foo_->ex1 = 1; foo_->ex2 = 2; foo_.GetArrayBuffer(); ``` Signed-off-by: James M Snell <[email protected]> PR-URL: #32778 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@jasnell@BethGriggs
src: add AliasedStruct utility
a946189
For http2 (and eventually QUIC) we have a struct that is backed by a v8::BackingStore and exposed to the JavaScript side as an ArrayBuffer and TypedArray. This is similar to AliasedBuffer except that it is fronted by a struct on the C++ side. ```c++ struct foo{uint32_t ex1; uint32_t ex2}; AliasedStruct<foo> foo_; foo_->ex1 = 1; foo_->ex2 = 2; foo_.GetArrayBuffer(); ``` Signed-off-by: James M Snell <[email protected]> PR-URL: #32778 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Apr 14, 2020
Merged
@sam-githubsam-github mentioned this pull request Apr 15, 2020
Closed
4 tasks
@joyeecheungjoyeecheung mentioned this pull request Apr 20, 2020
Closed
4 tasks
@joyeecheungjoyeecheung mentioned this pull request Jun 8, 2020
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@FlarnaFlarnaFlarna approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jasnell@richardlau@addaleax@nodejs-github-bot@Flarna@targos@BridgeAR