build: Intl: deps: bump ICU to 56.1 (GA)

[srl295]

• ICU 56 was just released yesterday. Update to it.
• Notable changes: Unicode 8, CLDR 28, 2-3x number format perf,
  20% improvement in Collator startup
  • more at http://site.icu-project.org/download/56 or in Intl: ICU 55 to 56 bump #2917

Fixes: #2917

@jasnell if you can land this in master also it would be great otherwise I will do later

[srl295]

test running https://ci.nodejs.org/job/node-test-pull-request/454/console
Note: i haven't mirrored the ICU url to our CDN yet. Hopefully server won't melt before I get a round tuit.

[jasnell]

One challenge in the CI build: "ok 469 test-intl.js # skip Intl tests because Intl object not present." ... it doesn't look like our CI is configured with --with-intl enabled (/cc @nodejs/build)

[jasnell]

@srl295 ... getting compile erros when attempting to run a build locally on Mac OS X 10.11

clang: error: clangno such file or directory: '../deps/icu/source/tools/genrb/reslist.c': error: no such file or directory: '../deps/icu/source/tools/genrb/genrb.c'clang: error : no input files clang: error: no input files g++ '-D_DARWIN_USE_64_BIT_INODE=1' '-DUCONFIG_NO_TRANSLITERATION=1' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DUCONFIG_NO_LEGACY_CONVERSION=1' '-DUCONFIG_NO_IDNA=1' -I../deps/icu/source/common -I../deps/icu/source/i18n -I../deps/icu/source/io -I../deps/icu/source/tools/toolutil -Os -gdwarf-2 -mmacosx-version-min=10.5 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -fno-rtti -fno-exceptions -fno-thre:clang: error: no such file or directory: '../deps/icu/source/tools/genrb/wrtjava.c' clang: error: no input files make[1]: *** [/Users/james/Node/main/node/out/Release/obj.host/genrb/deps/icu/source/tools/genrb/wrtjava.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: *** [/Users/james/Node/main/node/out/Release/obj.host/genrb/deps/icu/source/tools/genrb/genrb.o] Error 1 make[1]: *** [/Users/james/Node/main/node/out/Release/obj.host/genrb/deps/icu/source/tools/genrb/reslist.o] Error 1 ../deps/icu/source/tools/genrb/wrtxml.cpp:397:1: warning: unused function 'print' [-Wunused-function] print(UChar* src, int32_t srcLen,const char *tagStart,const char *tagEnd, UErrorCode *status){^ ../deps/icu/source/tools/genrb/wrtxml.cpp:472:13: warning: unused function 'printAttribute' [-Wunused-function] static void printAttribute(const char *name, const UnicodeString value, int32_t /*len*/) ^ ../tools/icu/iculslocs.cc:196:15: warning: unused variable 'isTable' [-Wunused-variable] const UBool isTable = (UBool)(ures_getType(bund.getAlias()) == URES_TABLE); ^ 1 warning generated. 2 warnings generated. make: *** [node] Error 2 

[srl295]

no such file ... genrb.c
@jasnell I think the above is due to one of the generated makefiles not being removed cleanly. In 56 that file is genrb.cpp.

[jasnell]

Ok, that's what I was figuring. I've removed the out directory manually and kicked off another build. I'll let you know how it goes. Can you please investigate to see if additional ICU cleanups need to be done by make clean?

I hesitate to land this yet because not everyone is going to build from a clean branch. The cleanup of the old deps/icu, icu zip and make files could trip others up. Ideally, make clean would fully reset and/or configure would catch that deps/icu and the icu zip are out of date and prepare accordingly

[srl295]

@jasnell okay, the offending file is: node/out/Release/.deps//home/srl/src/node/out/Release/obj.host/genrb/deps/icu/source/tools/genrb/genrb.o.d

Why doesn't make clean delete this? Looks like it only deletes *.o files. I assumed I was just doing it wrong™.

Should make clean deleting the .deps dir? For that matter should configure delete it?

[jasnell]

No objection from me. @nodejs/build @rvagg ... any opinions?

[Fishrock123]

https -- yes please!

[srl295]

@Fishrock123

https

Thanks for noticing. I had meant to do that before.

[srl295]

updated pr so make check deletes out/…/*.d and also deps/icu … (a notice is printed if deps/icu was removed)

[jasnell]

Ok, updated PR LGTM on OS X. Will spin up a windows test run shortly

[jasnell]

On windows, vcbuild.bat clean needs to be updated to remove the deps/icu directory. Other than that, build looks good. Once the PR is updated with the vcbuild changes, I'll do one more test pass then get it landed.

[jasnell]

LGTM! @mhdawson ... I'll be getting this landed in master... do you want to do some testing before I pull it into v4.x?

[jasnell]

Landed in 01908d0. Still need to land on v4.x

[jasnell]

Landed in v4.x with af24376