Skip to content

Conversation

@puzpuzpuz
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 13, 2020
@puzpuzpuzpuzpuzpuz added fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs. labels Apr 13, 2020
@Trott
Copy link
Member

Trott commented Apr 13, 2020

Collaborators, please 👍 here to fast-track.

@nodejs-github-bot
Copy link
Collaborator

puzpuzpuz added a commit that referenced this pull request Apr 13, 2020
PR-URL: #32817 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@puzpuzpuz
Copy link
MemberAuthor

Landed in 38bf1be

@puzpuzpuzpuzpuzpuz deleted the add-puzpuzpuz-to-collaborators branch April 13, 2020 15:57
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
PR-URL: #32817 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
PR-URL: nodejs#32817 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32817 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
BridgeAR added a commit that referenced this pull request Apr 28, 2020
Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) #31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) #31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) #32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol#32906 * Andrey Pechkurov @puzpuzpuz#32817 PR-URL: #33122
targos pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32817 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR added a commit that referenced this pull request Apr 28, 2020
Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) #31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) #31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) #32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol#32906 * Andrey Pechkurov @puzpuzpuz#32817 PR-URL: #33122
BridgeAR added a commit that referenced this pull request Apr 29, 2020
Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) #31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) #31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) #32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol#32906 * Andrey Pechkurov @puzpuzpuz#32817 PR-URL: #33122
@targostargos mentioned this pull request May 2, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@puzpuzpuz@Trott@nodejs-github-bot@addaleax@cjihrig