doc: add tsc-agenda to onboarding labels list#32832
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Apr 13, 2020
Trott added the author ready 
jasnell approved these changes Apr 15, 2020
jasnell reviewed Apr 15, 2020
doc/guides/onboarding-extras.md Outdated
Member
There was a problem hiding this comment.
Not sure if it is covered in detail elsewhere in the onboarding docs... but if not, it would be good to highlight that tsc-agenda should be used sparingly and only if the issue cannot be resolved through normal discourse.
trivikr approved these changes Apr 17, 2020
BridgeAR approved these changes Apr 17, 2020
PR-URL: nodejs#32832 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trottforce-pushed the tsc-agenda-onboarding branch from 13c255f to f67601cCompare
MemberAuthor
Trott commented Apr 18, 2020
Landed in f67601c |
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
PR-URL: #32832 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32832 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
PR-URL: #32832 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes