Skip to content

src: delete MicroTaskPolicy namespace#32853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juanarbol wants to merge 1 commit into from
Closed

src: delete MicroTaskPolicy namespace #32853

juanarbol wants to merge 1 commit into from

Conversation

@juanarbol
Copy link
Member

@juanarboljuanarbol commented Apr 14, 2020

Maybe you're tired of this kind of PR, but what I do is just read codebase, try to understand and make sure that every namespace is being used, sooner I'll be doing the same but with header files. Sorry for the kind of "spam" PR

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 14, 2020
mhdawson
mhdawson approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanarboljuanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 20, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30865/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 21, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30885/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30952/

puzpuzpuz pushed a commit that referenced this pull request Apr 24, 2020
@juanarbol@puzpuzpuz
src: delete MicroTaskPolicy namespace
1b2988a
PR-URL: #32853 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@puzpuzpuz
Copy link
Member

puzpuzpuz commented Apr 24, 2020

Landed in 1b2988a

BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@juanarbol@BethGriggs
src: delete MicroTaskPolicy namespace
ac0d6da
PR-URL: #32853 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol@BridgeAR
src: delete MicroTaskPolicy namespace
d3f65e8
PR-URL: #32853 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol@BridgeAR
src: delete MicroTaskPolicy namespace
bd096bd
PR-URL: #32853 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol@BethGriggs
src: delete MicroTaskPolicy namespace
d82c3c2
PR-URL: #32853 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2020
@juanarbol@targos
src: delete MicroTaskPolicy namespace
3ae6121
PR-URL: #32853 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@targostargos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@juanarbol@targos
src: delete MicroTaskPolicy namespace
846d7bd
PR-URL: #32853 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@juanarboljuanarbol deleted the juanarbol/remove-microtaskpolicy-np branch January 19, 2021 16:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@juanarbol@nodejs-github-bot@puzpuzpuz@fhinkel@jasnell@addaleax@cjihrig@BridgeAR@mhdawson