src: elevate v8 namespaces#32872
Closed
src: elevate v8 namespaces #32872
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Leverage `using` semantics for repeated usage of v8 artifacts.
nodejs-github-bot added c++ 
addaleax approved these changes Apr 15, 2020
cjihrig approved these changes Apr 15, 2020
gireeshpunathil approved these changes Apr 16, 2020
himself65 approved these changes Apr 16, 2020
Collaborator
nodejs-github-bot commented Apr 17, 2020
lpinca approved these changes Apr 17, 2020
BridgeAR approved these changes Apr 17, 2020
BridgeAR added the author ready gireeshpunathil pushed a commit that referenced this pull request Apr 18, 2020
elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: #32872 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Member
gireeshpunathil commented Apr 18, 2020
landed in e231e1a |
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: #32872 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: #32872 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: #32872 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverage
usingsemantics for repeated usage ofv8 artifacts.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes