stream: simplify Writable.end()#32882
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Simplifies Writable.end() by inlining and de-duplicating code.
nodejs-github-bot added the stream 
Collaborator
nodejs-github-bot commented Apr 16, 2020
addaleax approved these changes Apr 16, 2020
Collaborator
nodejs-github-bot commented Apr 16, 2020
ronag added the author ready 
lpinca approved these changes Apr 16, 2020
Flarna approved these changes Apr 16, 2020
Collaborator
nodejs-github-bot commented Apr 17, 2020
Collaborator
nodejs-github-bot commented Apr 17, 2020
BridgeAR approved these changes Apr 17, 2020
Collaborator
nodejs-github-bot commented Apr 18, 2020
MemberAuthor
ronag commented Apr 18, 2020
Landed in 73f3072 |
ronag added a commit that referenced this pull request Apr 18, 2020
Simplifies Writable.end() by inlining and de-duplicating code. PR-URL: #32882 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
Simplifies Writable.end() by inlining and de-duplicating code. PR-URL: #32882 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies Writable.end() by inlining and
de-duplicating code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes