Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
stream: inline unbuffered _write#32886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
ronag commented Apr 16, 2020 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot commented Apr 16, 2020
himself65 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
and should we add a comment like // inline doWrite(stream, state, false, len, chunk, encoding, cb) for better understand
ronag commented Apr 17, 2020
It's not exactly the same anymore, since some of the code that is not relevant is removed. So it might make it more confusing? |
PR-URL: #32886 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
ronag commented Apr 18, 2020
Landed in fd10be4 |
PR-URL: #32886 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #32886 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
A ~15% improvement for the sync case
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes