Skip to content

perf_hooks: remove unnecessary assignment operations#32910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rickyes wants to merge 1 commit into from
Closed

perf_hooks: remove unnecessary assignment operations #32910

rickyes wants to merge 1 commit into from

Conversation

@rickyes
Copy link
Contributor

@rickyesrickyes commented Apr 18, 2020•
edited
Loading

Remove unnecessary assignment operations when name is undefined.

/cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Apr 18, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 18, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30828/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 18, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30830/

@legendecaslegendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 19, 2020
puzpuzpuz pushed a commit that referenced this pull request Apr 20, 2020
@rickyes@puzpuzpuz
perf_hooks: remove unnecessary assignment when name is undefined
f250adb
PR-URL: #32910 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@puzpuzpuz
Copy link
Member

puzpuzpuz commented Apr 20, 2020

Landed in f250adb

@rickyesrickyes deleted the refactor-clearMark branch April 20, 2020 14:38
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@rickyes@BethGriggs
perf_hooks: remove unnecessary assignment when name is undefined
a133ac1
PR-URL: #32910 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@rickyes@BridgeAR
perf_hooks: remove unnecessary assignment when name is undefined
7bd51fb
PR-URL: #32910 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@rickyes@targos
perf_hooks: remove unnecessary assignment when name is undefined
ad15f49
PR-URL: #32910 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@rickyes@targos
perf_hooks: remove unnecessary assignment when name is undefined
8dcb22f
PR-URL: #32910 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@legendecaslegendecaslegendecas approved these changes

@himself65himself65himself65 approved these changes

+1 more reviewer

@puzpuzpuzpuzpuzpuzpuzpuzpuz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.perf_hooksIssues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@rickyes@nodejs-github-bot@puzpuzpuz@jasnell@lpinca@targos@cjihrig@legendecas@himself65