path: fix comment grammar#32942
Closed
path: fix comment grammar #32942
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Apr 27, 2020
addaleax added the author ready 
devsnek approved these changes Apr 27, 2020
Collaborator
nodejs-github-bot commented Apr 28, 2020
MrHeer approved these changes Apr 28, 2020
addaleax pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32942 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Member
addaleax commented Apr 28, 2020
Landed in d0377a8 🎉 Thanks for being patient with us! |
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #32942 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #32942 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32942 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my first PR.
I was looking through the
path.jssource code and saw some grammar mistakes in one of the comments. Thought it would make a good first PR.Checklist