doc: add more info to v14 changelog#32979
Uh oh!
There was an error while loading. Please reload this page.
Conversation
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
A corresponding update should be made on the blog post: https://github.com/nodejs/nodejs.org/blob/master/locale/en/blog/release/v14.0.0.md
devsnek commented Apr 21, 2020
What are the rules on merging doc-only changes? |
GaryGSC commented Apr 21, 2020
https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#waiting-for-approvals
|
jasnell commented Apr 21, 2020
In general, the rules are the same as any commit unless fast-track is ok'd by at least two collaborators. |
devsnek commented Apr 21, 2020
👍 to fast track? |
richardlau commented Apr 21, 2020
https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#testing-and-ci
i.e. doc-only changes do not require Jenkins CI to be run but do require the GitHub Actions to pass. |
PR-URL: #32979 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
devsnek commented Apr 22, 2020
landed in d08bd41 |
PR-URL: #32979 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes