Skip to content

lib: simplify function process.emitWarning#32992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
himself65 wants to merge 1 commit into from
Closed

lib: simplify function process.emitWarning #32992

himself65 wants to merge 1 commit into from

Conversation

@himself65
Copy link
Member

@himself65himself65 commented Apr 22, 2020•
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the process Issues and PRs related to the process subsystem. label Apr 22, 2020
mscdex
mscdex reviewed Apr 22, 2020
View reviewed changes
@himself65himself65 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 23, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30918/

puzpuzpuz pushed a commit that referenced this pull request Apr 24, 2020
@himself65@puzpuzpuz
lib: simplify function process.emitWarning
d01a06a
PR-URL: #32992 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
@puzpuzpuz
Copy link
Member

puzpuzpuz commented Apr 24, 2020

Landed in d01a06a

BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@himself65@BethGriggs
lib: simplify function process.emitWarning
b152026
PR-URL: #32992 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@himself65@BridgeAR
lib: simplify function process.emitWarning
944dceb
PR-URL: #32992 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@himself65@BridgeAR
lib: simplify function process.emitWarning
2c364d4
PR-URL: #32992 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@himself65@BethGriggs
lib: simplify function process.emitWarning
98b30b0
PR-URL: #32992 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@juanarboljuanarboljuanarbol approved these changes

+2 more reviewers

@mscdexmscdexmscdex left review comments

@puzpuzpuzpuzpuzpuzpuzpuzpuz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@himself65@nodejs-github-bot@puzpuzpuz@mscdex@jasnell@targos@cjihrig@BridgeAR@juanarbol