Skip to content

deps: V8: backport 3f8dc4b2e5ba#32993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ryzokuken wants to merge 1 commit into from
Closed

deps: V8: backport 3f8dc4b2e5ba #32993

ryzokuken wants to merge 1 commit into from

Conversation

@ryzokuken
Copy link
Contributor

@ryzokukenryzokuken commented Apr 22, 2020

Original commit message:

[intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027}

Refs: v8/v8@3f8dc4b

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @targos@mmarchini@srl295

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Apr 22, 2020
@ryzokukenryzokuken self-assigned this Apr 22, 2020
richardlau
richardlau reviewed Apr 23, 2020
View reviewed changes
srl295
srl295 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@srl295srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Icu 67.1 imminent!

@ryzokuken
Copy link
ContributorAuthor

ryzokuken commented Apr 27, 2020

@richardlau done, PTAL. I'll land this later today after your LG.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31000/

@targos
Copy link
Member

targos commented Apr 27, 2020

@ryzokuken you need to rebase, there's a conflict

@ryzokuken
deps: V8: backport 3f8dc4b2e5ba
19e8c4a
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027} Refs: v8/v8@3f8dc4b
@ryzokuken
Copy link
ContributorAuthor

ryzokuken commented Apr 27, 2020

@targos done :D

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31001/

@ryzokuken
Copy link
ContributorAuthor

ryzokuken commented Apr 27, 2020

Is V8 CI okay, or am I doing something wrong? https://ci.nodejs.org/job/node-test-commit-v8-linux/3070/console

@targos
Copy link
Member

targos commented Apr 27, 2020

@ryzokukenGIT_REMOTE_REF should be refs/pull/32993/head

@ryzokuken
Copy link
ContributorAuthor

ryzokuken commented Apr 27, 2020

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3071/

@ryzokuken
Copy link
ContributorAuthor

ryzokuken commented Apr 27, 2020

Both builds were successful, landing this.

ryzokuken added a commit that referenced this pull request Apr 27, 2020
@ryzokuken
deps: V8: backport 3f8dc4b2e5ba
b37ec37
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027} Refs: v8/v8@3f8dc4b PR-URL: #32993 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@ryzokuken
Copy link
ContributorAuthor

ryzokuken commented Apr 27, 2020

Landed in b37ec37

BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@ryzokuken@BethGriggs
deps: V8: backport 3f8dc4b2e5ba
7a9538a
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027} Refs: v8/v8@3f8dc4b PR-URL: #32993 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@ryzokuken@BridgeAR
deps: V8: backport 3f8dc4b2e5ba
3956ab5
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027} Refs: v8/v8@3f8dc4b PR-URL: #32993 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@ryzokuken@BridgeAR
deps: V8: backport 3f8dc4b2e5ba
5caa627
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027} Refs: v8/v8@3f8dc4b PR-URL: #32993 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@ryzokuken@BethGriggs
deps: V8: backport 3f8dc4b2e5ba
b50333e
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027} Refs: v8/v8@3f8dc4b PR-URL: #32993 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2020
@ryzokuken@targos
deps: V8: backport 3f8dc4b2e5ba
68787ab
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027} Refs: v8/v8@3f8dc4b PR-URL: #32993 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@targostargos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@ryzokuken@targos
deps: V8: backport 3f8dc4b2e5ba
eb33d52
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#67027} Refs: v8/v8@3f8dc4b PR-URL: #32993 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295srl295srl295 approved these changes

@targostargostargos approved these changes

@richardlaurichardlaurichardlau approved these changes

+1 more reviewer

@mmarchinimmarchinimmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ryzokukenryzokuken

Labels

buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ryzokuken@nodejs-github-bot@targos@srl295@mmarchini@richardlau