test: remove util properties from common#3304
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
common does not need util properties anymore. Remove them.
MemberAuthor
Trott commented Oct 9, 2015
Contributor
Fishrock123 commented Oct 9, 2015
LGTM if CI is happy |
Contributor
brendanashworth commented Oct 10, 2015
LGTM too. |
Contributor
thefourtheye commented Oct 10, 2015
LGTM |
MemberAuthor
Trott commented Oct 12, 2015
Landed in 3202456 |
Trott added a commit that referenced this pull request Oct 12, 2015
common does not need util properties anymore. Remove them. PR-URL: #3304 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Oct 27, 2015
Trott added a commit that referenced this pull request Oct 28, 2015
common does not need util properties anymore. Remove them. PR-URL: #3304 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Member
jasnell commented Oct 28, 2015
Landed in v4.x-staging in 4c411ae |
Trott added a commit that referenced this pull request Oct 29, 2015
common does not need util properties anymore. Remove them. PR-URL: #3304 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Feb 20, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commondoes not needutilproperties anymore. Remove them.