tools: update broken types in type parser#33068
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
juanarbol approved these changes Apr 25, 2020
lpinca approved these changes Apr 26, 2020
jasnell approved these changes Apr 27, 2020
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Apr 27, 2020
Collaborator
The links for the ArrayBufferView and WebAssembly.Instance types appear to be broken. This commit updates them to point to the correct MDN locations. PR-URL: nodejs#33068 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 4, 2020
The links for the ArrayBufferView and WebAssembly.Instance types appear to be broken. This commit updates them to point to the correct MDN locations. PR-URL: #33068 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
The links for the ArrayBufferView and WebAssembly.Instance types appear to be broken. This commit updates them to point to the correct MDN locations. PR-URL: #33068 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
The links for the ArrayBufferView and WebAssembly.Instance types appear to be broken. This commit updates them to point to the correct MDN locations. PR-URL: #33068 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The links for the
ArrayBufferViewandWebAssembly.Instancetypes appear to be broken. This commit updates them to point to the correct MDN locations.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes