Skip to content

Conversation

@targos
Copy link
Member

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Apr 26, 2020
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2020

@bricssbricss mentioned this pull request Apr 28, 2020
@addaleax
Copy link
Member

Fast-track this because including it in v14.1.0 (#33103) has been requested and it’s only a few hours anyway? I’m okay with that.

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 28, 2020
@targos
Copy link
MemberAuthor

no objections

addaleax pushed a commit that referenced this pull request Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31 PR-URL: #33080 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
@addaleax
Copy link
Member

Landed in 563efb7

@targostargos deleted the patchv8 branch April 28, 2020 13:59
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31 PR-URL: #33080 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31 PR-URL: #33080 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
@targostargos added dont-land-on-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@addaleax@cjihrig@devsnek@juanarbol