doc: made grammar more consistent and correct#33081
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
juanarbol approved these changes Apr 27, 2020
Member
juanarbol left a comment
juanarbol left a comment There was a problem hiding this comment.
This is great! Thank you so much for your contribution.
addaleax approved these changes Apr 27, 2020
addaleax added the author ready 
Trott reviewed Apr 28, 2020
| 1. Checkout the staging branch for the targeted release line | ||
| 2. Make sure that the local staging branch is up to date with the remote | ||
| 3. Create a new branch off of the staging branch | ||
| 1. Checkout the staging branch for the targeted release line. |
Member
There was a problem hiding this comment.
While we're in here, maybe this too?
Suggested change
| 1.Checkout the staging branch for the targeted release line. | |
| 1.Check out the staging branch for the targeted release line. |
ContributorAuthor
There was a problem hiding this comment.
Are we sure we'd want to change this considering it's in reference to the git checkout command?
Member
There was a problem hiding this comment.
I’ll go ahead with landing this as this PR hasn’t modified that part.
Trott approved these changes Apr 28, 2020
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
LGTM with or without my suggestion
addaleax pushed a commit that referenced this pull request Apr 29, 2020
PR-URL: #33081 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
addaleax commented Apr 29, 2020
Landed in a9b8f70, thanks for the PR! |
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #33081 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #33081 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #33081 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file contained a few grammatical mistakes and inconsistencies. This pull request makes those simple fixes. Reopening of #32957 after I accidentally deleted the branch.
Checklist