repl: improve repl preview#33282

BridgeAR · 2020-05-07T16:28:33Z

Please check the commit messages for details.

@nodejs/repl

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This aligns the REPL preview with the one used in the Chrome DevTools console. It will now preview the output for the input including the completion suffix as input. When pressing enter while previewing such data, it will automatically insert the suffix before evaluating the input. When pressing escape, that behavior is deactivated until the input is changed. Signed-off-by: Ruben Bridgewater <[email protected]>

This aligns the behavior with the one in the Firefox console. It will visualize ReferenceErrors in case the input has no possible completion and no buffered input. That way typos can already be highlighted before being evaluated. Signed-off-by: Ruben Bridgewater <[email protected]>

This replaces the internally used hard coded Node.js core module list with the actual internal existent modules. That way all modules are automatically picked up instead of having to update the list manually. This currently only applies to the REPL and to the Node.js `eval` functionality (User passed `-e` or `--eval` arguments to Node without `-i` or `--interactive`). Signed-off-by: Ruben Bridgewater <[email protected]>

This simplifies the test a bit by removing duplicated code and by focusing the reader on the passed through module. Signed-off-by: Ruben Bridgewater <[email protected]>

This improves the autocompletion for require calls. It had multiple small issues so far. Most important: it won't suggest completions for require statements that are fully written out. Second, it'll detect require calls that have whitespace behind the opening bracket. Third, it makes sure node modules are detected as such instead of only suggesting them as folders. Last, it adds suggestions for input that starts with backticks. Fixes: nodejs#33238 Signed-off-by: Ruben Bridgewater <[email protected]>

BridgeAR · 2020-05-09T23:22:50Z

@nodejs/repl PTAL. This could use some reviews.

targos · 2020-05-10T12:38:15Z

I really like the behavior with the first commit!

I do not understand how the second one works, though (repl: show reference errors during preview). I tried to start node with --use-strict, which throws ReferenceError for bad assignments but the behavior of the REPL doesn't change.

BridgeAR · 2020-05-11T07:33:05Z

@targos thanks, I did not include a check to detect --use-strict. That is actually a V8 feature and not from Node.js. As such we lack any documentation of it and we implemented a own way to use the strict mode with the REPL: NODE_REPL_MODE = 'strict'.

This adds support for `--use-strict`. Signed-off-by: Ruben Bridgewater <[email protected]>

BridgeAR · 2020-05-11T12:22:26Z

I added support for --use-strict as well, since it does seem to be useful for the REPL.

nodejs-github-bot · 2020-05-11T13:07:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31275/

nodejs-github-bot · 2020-05-12T16:04:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31292/

Notable changes: async_hooks: * (SEMVER-MINOR) move PromiseHook handler to JS (Stephen Belanger) #32891 cli: * (SEMVER-MINOR) add `--trace-atomics-wait` flag (Anna Henningsen) #33292 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) #33134 http: * (SEMVER-MINOR) expose http.validate-header-name/value (osher) #33119 repl: * (SEMVER-MINOR) deprecate repl._builtinLibs (Ruben Bridgewater) #33294 * (SEMVER-MINOR) deprecate repl.inputStream and repl.outputStream (Ruben Bridgewater) #33294 * (SEMVER-MINOR) show reference errors during preview (Ruben Bridgewater) #33282 * (SEMVER-MINOR) improve repl preview (Ruben Bridgewater) #33282 src: * add support for TLA (Gus Caplan) #30370 PR-URL: TODO

Notable changes: async_hooks: * (SEMVER-MINOR) move PromiseHook handler to JS (Stephen Belanger) #32891 cli: * (SEMVER-MINOR) add `--trace-atomics-wait` flag (Anna Henningsen) #33292 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) #33134 http: * (SEMVER-MINOR) expose http.validate-header-name/value (osher) #33119 repl: * (SEMVER-MINOR) deprecate repl._builtinLibs (Ruben Bridgewater) #33294 * (SEMVER-MINOR) deprecate repl.inputStream and repl.outputStream (Ruben Bridgewater) #33294 * (SEMVER-MINOR) show reference errors during preview (Ruben Bridgewater) #33282 * (SEMVER-MINOR) improve repl preview (Ruben Bridgewater) #33282 src: * add support for TLA (Gus Caplan) #30370 PR-URL: #33452

MylesBorins · 2020-08-17T21:59:20Z

Is this something we want to backport to v12.x? Based on the various commits referencing this PR I'm imagining it might need to be a couple different PRs all at once.

addaleax · 2020-11-25T11:21:47Z

@BridgeAR @jasnell @targos This uses blocking operations for autocompletion. Can we revert this, or fix that? It’s extremely annoying that the repl hangs for an indefinite amount of time when you type require(' when your node_modules directory is large. It also doesn’t seem necessary, given that the autocomplete API is designed to be asynchronous.

It’s not okay for the REPL to be blocked for multiple seconds after entering `require('` because the completion is performing blocking fs operations on potentially huge directories. Turning the REPL completion function asynchronous would be the right thing to do here, but unfortunately the way the code is structured doesn’t play well with that (in particular, it breaks the preview feature). Therefore, disable these blocking calls by default. Refs: nodejs#33282 (comment)

addaleax · 2020-12-18T14:00:47Z

Since there’s been no reply, I’ve opened #36564 to disable this by default.

It’s not okay for the REPL to be blocked for multiple seconds after entering `require('` because the completion is performing blocking fs operations on potentially huge directories. Turning the REPL completion function asynchronous would be the right thing to do here, but unfortunately the way the code is structured doesn’t play well with that (in particular, it breaks the preview feature). Therefore, disable these blocking calls by default. Refs: #33282 (comment) PR-URL: #36564 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Refs: nodejs#33238 Refs: nodejs#33282

Refs: nodejs#33238 Refs: nodejs#33282 Co-authored-by: Antoine du Hamel <[email protected]>

Refs: nodejs#33238 Refs: nodejs#33282 Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: nodejs#37178 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #33238 Refs: #33282 Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #37178 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>

It’s not okay for the REPL to be blocked for multiple seconds after entering `require('` because the completion is performing blocking fs operations on potentially huge directories. Turning the REPL completion function asynchronous would be the right thing to do here, but unfortunately the way the code is structured doesn’t play well with that (in particular, it breaks the preview feature). Therefore, disable these blocking calls by default. Refs: #33282 (comment) PR-URL: #36564 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Refs: nodejs#33238 Refs: nodejs#33282 Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: nodejs#37178 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #33238 Refs: #33282 Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #37178 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>

BridgeAR requested review from jasnell and targos May 7, 2020 16:28

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label May 7, 2020

BridgeAR added 2 commits May 7, 2020 18:44

BridgeAR force-pushed the improve-repl-preview branch from e8bcc7c to 7821dd2Compare May 7, 2020 16:44

This comment has been minimized.
Sign in to view

BridgeAR force-pushed the improve-repl-preview branch from 585ca68 to c410d68Compare May 7, 2020 19:01

This comment has been minimized.
Sign in to view

BridgeAR added 2 commits May 8, 2020 01:35

test: refactor test/parallel/test-bootstrap-modules.js
c24445d
This simplifies the test a bit by removing duplicated code and by focusing the reader on the passed through module. Signed-off-by: Ruben Bridgewater <[email protected]>

BridgeAR force-pushed the improve-repl-preview branch from c410d68 to 00cd4d8Compare May 7, 2020 23:35

This comment has been minimized.
Sign in to view

This was referenced May 8, 2020
repl: deprecate duplicated repl features #33294
Closed
repl: add builtinModules #33295
Closed

This comment has been minimized.
Sign in to view

BridgeAR added the semver-minor PRs that contain new features and should be released in the next minor version. label May 10, 2020

fixup! repl: show reference errors during preview
abc2bda
This adds support for `--use-strict`. Signed-off-by: Ruben Bridgewater <[email protected]>

BridgeAR force-pushed the improve-repl-preview branch from 88c5344 to abc2bdaCompare May 11, 2020 12:23

jasnell approved these changes May 11, 2020
View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2020

targos approved these changes May 12, 2020
View reviewed changes

MylesBorins added the backport-requested-v12.x label Aug 17, 2020

addaleax added dont-land-on-v12.x and removed backport-requested-v12.x labels Sep 23, 2020

addaleax mentioned this pull request Dec 18, 2020
repl: disable blocking completions by default #36564
Closed
2 tasks

ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Feb 2, 2021
repl: add autocompletion for dynamic import calls
ac16758
Refs: nodejs#33238 Refs: nodejs#33282

ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Feb 2, 2021
repl: add auto‑completion for dynamic import calls
5a47430
Refs: nodejs#33238 Refs: nodejs#33282

ExE-Boss mentioned this pull request Feb 2, 2021
repl: add auto‑completion for dynamic import calls #37178
Merged
1 task

ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Feb 4, 2021
repl: add auto‑completion for dynamic import calls
9548210
Refs: nodejs#33238 Refs: nodejs#33282 Co-authored-by: Antoine du Hamel <[email protected]>

ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Feb 4, 2021
repl: add auto‑completion for dynamic import calls
f41cddd
Refs: nodejs#33238 Refs: nodejs#33282 Co-authored-by: Antoine du Hamel <[email protected]>

Uh oh!

repl: improve repl preview#33282

repl: improve repl preview #33282

Uh oh!

Conversation

BridgeAR commented May 7, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

BridgeAR commented May 9, 2020

Uh oh!

targos commented May 10, 2020

Uh oh!

BridgeAR commented May 11, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented May 11, 2020

Uh oh!

nodejs-github-bot commented May 11, 2020

Uh oh!

nodejs-github-bot commented May 12, 2020

Uh oh!

MylesBorins commented Aug 17, 2020

Uh oh!

addaleax commented Nov 25, 2020

Uh oh!

addaleax commented Dec 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BridgeAR commented May 7, 2020•
edited
Loading

BridgeAR commented May 11, 2020•
edited
Loading