test,quic: add common/udppair utility for quic#33380
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
jasnell changed the title jasnell added the quic 
sam-github approved these changes May 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
aks- approved these changes May 13, 2020
Collaborator
nodejs-github-bot commented May 23, 2020
BridgeARforce-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72Compare
Extracted from the QUIC PR. This adds a utility used to deterministically test UDP traffic. It is currently only used by the experimental QUIC implementation. Separated out on request to make review easier.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Jun 15, 2020
Collaborator
nodejs-github-bot commented Jun 16, 2020
jasnell added a commit that referenced this pull request Jun 16, 2020
Extracted from the QUIC PR. This adds a utility used to deterministically test UDP traffic. It is currently only used by the experimental QUIC implementation. Separated out on request to make review easier. PR-URL: #33380 Reviewed-By: Sam Roberts <[email protected]>
MemberAuthor
jasnell commented Jun 16, 2020
Landed in a808cb7 |
18 tasks
codebytere pushed a commit that referenced this pull request Jun 18, 2020
Extracted from the QUIC PR. This adds a utility used to deterministically test UDP traffic. It is currently only used by the experimental QUIC implementation. Separated out on request to make review easier. PR-URL: #33380 Reviewed-By: Sam Roberts <[email protected]>
This was referenced Jun 19, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Extracted from the QUIC PR. This adds a utility used to deterministically test UDP traffic. It is currently only used by the experimental QUIC implementation. Separated out on request to make review easier. PR-URL: #33380 Reviewed-By: Sam Roberts <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 26, 2020
Extracted from the QUIC PR. This adds a utility used to deterministically test UDP traffic. It is currently only used by the experimental QUIC implementation. Separated out on request to make review easier. PR-URL: #33380 Reviewed-By: Sam Roberts <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from the QUIC PR. This adds a utility used to deterministically test UDP traffic. It is currently only used by the experimental QUIC implementation. Separated out on request to make review easier.
There are no tests here because it has been implemented around the QUIC implementation in that the udp_wrap listener needs to be attached at the c++ level, and outside of QUIC there's nothing we have in core that needs that.
This change has been separated out but should not land until the QUIC PR lands.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes