http: simplify Agent initialization#33551
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes May 25, 2020
BridgeAR approved these changes May 25, 2020
MrHeer approved these changes May 25, 2020
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/31550/ 💛 (known flake: parallel/test-http2-reset-flood) |
lundibundi approved these changes May 25, 2020
BridgeAR added the author ready 
lpinca approved these changes May 25, 2020
Member
lpinca commented May 25, 2020
Subsystem in commit message should be |
jasnell approved these changes May 25, 2020
himself65 changed the title 
ronag approved these changes May 27, 2020
Collaborator
nodejs-github-bot commented May 28, 2020
Collaborator
nodejs-github-bot commented May 28, 2020
himself65 added a commit that referenced this pull request May 28, 2020
PR-URL: #33551 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
MemberAuthor
himself65 commented May 28, 2020
landed in f19a576 |
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33551 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33551 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Member
codebytere commented Jul 8, 2020
Blocked on v12.x for the same reason #32801 is blocked. |
This was referenced Jan 25, 2022
This was referenced Jan 25, 2022
This was referenced Sep 27, 2022
This was referenced Sep 28, 2022
This was referenced Dec 15, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes