[v12.x] deps: V8: backport fb26d0bb1835#33573
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
Collaborator
BridgeAR changed the title 
BridgeAR added the author ready 
ContributorAuthor
mmarchini commented Jun 4, 2020
@targos would it be better if V8 fixed this on 7.8, or should we just keep this as a floating patch? The patch is not that big (without tests), and since it's unlikely we bump to 7.9 before October anyway the patch shouldn't bring any headaches. (also cc @codebytere, as I'm not sure how floating patches impact Electron) |
Member
targos commented Jun 4, 2020
I'm not sure what you mean? This V8 branch is no longer supported upstream |
ContributorAuthor
mmarchini commented Jun 4, 2020
I see. In the issue it sounded like they were open to fixing it on 7.8, but maybe they meant if it is absolutely necessary. |
codebytere approved these changes Jun 6, 2020
Member
codebytere commented Jun 6, 2020
@mmarchini it should be fine on our end! |
Merged
Member
codebytere commented Jun 9, 2020
@mmarchini this needs to be rebased against latest |
ContributorAuthor
mmarchini commented Jun 17, 2020
I missed the notification :( We'll need to wait until the July release now, correct? |
mmarchiniforce-pushed the v12.x-backport-gc-fix branch from 72d8e76 to e86be5cCompareCollaborator
Original commit message: [objects] Compact and shrink script_list So far creating scripts always grew the script_list without ever reusing cleared slots or shrinking. While this is probably not a problem with script_list in practice, this is still a memory leak. Fix this leak by using WeakArrayList::Append instead of AddToEnd. Append adds to the end of the array, but potentially compacts and shrinks the list as well. Other WeakArrayLists can use this method as well, as long as they are not using indices into this array. Bug: v8:10031 Change-Id: If743c4cc3f8d67ab735522f0ded038b2fb43e437 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967385 Commit-Queue: Dominik Inführ <[email protected]> Reviewed-by: Ulan Degenbaev <[email protected]> Cr-Commit-Position: refs/heads/master@{#65640} Refs: v8/v8@fb26d0b
mmarchiniforce-pushed the v12.x-backport-gc-fix branch from e86be5c to 1f9566bCompareContributorAuthor
mmarchini commented Jun 17, 2020
@codebytere rebased :) Did you get a conflict when using the release tools, or test errors? It rebased cleanly here, just had to bump the embedder string. |
This was referenced Jun 18, 2020
BethGriggs approved these changes Jun 26, 2020
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Jun 26, 2020
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/32109/ (Resume due to socket hang up on arm) ✅ |
BethGriggs pushed a commit that referenced this pull request Jun 26, 2020
Original commit message: [objects] Compact and shrink script_list So far creating scripts always grew the script_list without ever reusing cleared slots or shrinking. While this is probably not a problem with script_list in practice, this is still a memory leak. Fix this leak by using WeakArrayList::Append instead of AddToEnd. Append adds to the end of the array, but potentially compacts and shrinks the list as well. Other WeakArrayLists can use this method as well, as long as they are not using indices into this array. Bug: v8:10031 Change-Id: If743c4cc3f8d67ab735522f0ded038b2fb43e437 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967385 Commit-Queue: Dominik Inführ <[email protected]> Reviewed-by: Ulan Degenbaev <[email protected]> Cr-Commit-Position: refs/heads/master@{#65640} Refs: v8/v8@fb26d0b PR-URL: #33573 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Member
BethGriggs commented Jun 26, 2020
Landed in 97a3f7b (v12.x-staging) |
BethGriggs added a commit that referenced this pull request Jun 26, 2020
Merged
BethGriggs added a commit that referenced this pull request Jun 26, 2020
BethGriggs added a commit that referenced this pull request Jun 30, 2020
This was referenced Jul 1, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@fb26d0b
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes